Skip to content

Commit d45b6a5

Browse files
krassowskiCopilot
andauthored
Apply suggestions from code review
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
1 parent eb2df53 commit d45b6a5

2 files changed

Lines changed: 4 additions & 2 deletions

File tree

test/e2e/helpers.ts

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -125,8 +125,9 @@ export async function runFirstNotebookCell(
125125
.catch(() => undefined);
126126
await lab.waitForFunction(
127127
() => {
128-
const text =
129-
document.querySelector('#jp-main-statusbar')?.textContent ?? '';
128+
const el = document.querySelector('#jp-main-statusbar');
129+
const text = el?.textContent ?? '';
130+
if (!el || text.trim().length === 0) return false;
130131
return !['Connecting', 'Initializing', 'Starting'].some(s =>
131132
text.includes(s)
132133
);

test/e2e/smoke.test.ts

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -67,6 +67,7 @@ test('an electronAPI channel round-trips to the main process', async () => {
6767
const { app, userDataDir, jupyterDir } = await launchApp();
6868
try {
6969
const welcome = await pageByTitle(app, /welcome/i);
70+
await welcome.waitForLoadState('domcontentloaded');
7071
const isDark = await welcome.evaluate(() =>
7172
((window as unknown) as {
7273
electronAPI: { isDarkTheme(): Promise<boolean> };

0 commit comments

Comments
 (0)