test(e2e): share the lab-URL pattern and skip reason across the suite

Move the booted-server URL regex (was duplicated inline in three tests and a
local const in a fourth) and the 'set JLAB_TEST_PYTHON_PATH' skip reason into
helpers as LAB_URL and NEEDS_PYTHON, and use them everywhere so every
server-backed test waits on and skips for the same thing. No behavior change.

Note: AI-assisted (Claude Code). Manually verified: full e2e suite green
locally with --workers=1 (10 passed), eslint and prettier clean.

Author: notluquis

test/e2e/helpers.ts

@@ -4,6 +4,16 @@ import { mkdtempSync, rmSync, writeFileSync } from 'fs';
 import { join } from 'path';
 import { tmpdir } from 'os';
 
+// A booted JupyterLab server URL: the labview navigates here once a session is
+// up. Shared so every server-backed test waits on the same pattern.
+export const LAB_URL = /https?:\/\/(127\.0\.0\.1|localhost):\d+/;
+
+// The env-backed tests need a real Python with jupyterlab; CI provisions one and
+// points JLAB_TEST_PYTHON_PATH at it. Shared so the skip reason reads the same
+// everywhere.
+export const NEEDS_PYTHON =
+  'set JLAB_TEST_PYTHON_PATH to a python with jupyterlab';
+
 // A fresh userData dir per launch keeps tests independent. Electron's native
 // --user-data-dir flag is honored because the app reads app.getPath('userData')
 // (see getUserDataDir in utils) and only overrides it on Snap. Returns the app

test/e2e/jupyter-isolation.test.ts

@@ -2,7 +2,14 @@ import { expect, test } from '@playwright/test';
 import { existsSync, readdirSync } from 'fs';
 import { homedir } from 'os';
 import { join } from 'path';
-import { cleanup, launchApp, pageByTitle, pageByUrl } from './helpers';
+import {
+  cleanup,
+  LAB_URL,
+  launchApp,
+  NEEDS_PYTHON,
+  pageByTitle,
+  pageByUrl
+} from './helpers';
 
 // Needs a real Python env with jupyterlab. CI provisions one and points
 // JLAB_TEST_PYTHON_PATH at it. Skipped when absent so the suite stays green
@@ -34,10 +41,7 @@ function listDir(dir: string): string[] {
 }
 
 test('the embedded Jupyter server writes only to the per-launch temp dirs', async () => {
-  test.skip(
-    !pythonPath,
-    'set JLAB_TEST_PYTHON_PATH to a python with jupyterlab'
-  );
+  test.skip(!pythonPath, NEEDS_PYTHON);
   test.setTimeout(120000);
 
   const realRuntime = realRuntimeDir();
@@ -53,7 +57,7 @@ test('the embedded Jupyter server writes only to the per-launch temp dirs', asyn
 
     // Booting the labview means a real Jupyter server came up. Only then is it
     // meaningful to inspect where it wrote its runtime files.
-    await pageByUrl(app, /https?:\/\/(127\.0\.0\.1|localhost):\d+/);
+    await pageByUrl(app, LAB_URL);
 
     // The server used the redirected runtime dir: a connection file landed there.
     const tempRuntimeFiles = listDir(tempRuntime);

test/e2e/python-env.test.ts

@@ -1,16 +1,20 @@
 import { expect, test } from '@playwright/test';
-import { cleanup, launchApp, pageByTitle, pageByUrl } from './helpers';
+import {
+  cleanup,
+  LAB_URL,
+  launchApp,
+  NEEDS_PYTHON,
+  pageByTitle,
+  pageByUrl
+} from './helpers';
 
 // Needs a real Python env with jupyterlab. CI provisions one and points
 // JLAB_TEST_PYTHON_PATH at it; locally, set it to any python that has jupyterlab
 // installed. Skipped when absent so the suite stays green everywhere.
 const pythonPath = process.env.JLAB_TEST_PYTHON_PATH;
 
 test('with a seeded Python env, New notebook opens the labview', async () => {
-  test.skip(
-    !pythonPath,
-    'set JLAB_TEST_PYTHON_PATH to a python with jupyterlab'
-  );
+  test.skip(!pythonPath, NEEDS_PYTHON);
   test.setTimeout(120000);
   const { app, userDataDir, jupyterDir } = await launchApp({ pythonPath });
   try {
@@ -23,7 +27,7 @@ test('with a seeded Python env, New notebook opens the labview', async () => {
     // The session boots a real Jupyter server (via the seeded env) and the
     // labview WebContentsView navigates to it. Assert it reached the local
     // server URL rather than driving the JupyterLab DOM through Electron.
-    const lab = await pageByUrl(app, /https?:\/\/(127\.0\.0\.1|localhost):\d+/);
+    const lab = await pageByUrl(app, LAB_URL);
     expect(lab.url()).toMatch(/\/lab/);
   } finally {
     await app.close();

test/e2e/remote-session.test.ts

@@ -7,6 +7,7 @@ import { tmpdir } from 'os';
 import {
   cleanup,
   launchApp,
+  NEEDS_PYTHON,
   pageByLocator,
   pageByTitle,
   pageByUrl
@@ -97,10 +98,7 @@ async function startRemoteServer(
 }
 
 test('Connect to a running server opens its labview', async () => {
-  test.skip(
-    !pythonPath,
-    'set JLAB_TEST_PYTHON_PATH to a python with jupyterlab'
-  );
+  test.skip(!pythonPath, NEEDS_PYTHON);
   test.setTimeout(150000);
 
   const rootDir = mkdtempSync(join(tmpdir(), 'jlab-e2e-remote-'));

test/e2e/session-actions.test.ts

@@ -3,7 +3,14 @@ import { stubDialog } from 'electron-playwright-helpers';
 import { mkdtempSync, rmSync, writeFileSync } from 'fs';
 import { tmpdir } from 'os';
 import { join } from 'path';
-import { cleanup, launchApp, pageByTitle, pageByUrl } from './helpers';
+import {
+  cleanup,
+  LAB_URL,
+  launchApp,
+  NEEDS_PYTHON,
+  pageByTitle,
+  pageByUrl
+} from './helpers';
 
 // These cover the welcome-page session actions other than New notebook (which
 // python-env.test.ts already exercises): New session (blank lab), Open folder,
@@ -14,8 +21,6 @@ import { cleanup, launchApp, pageByTitle, pageByUrl } from './helpers';
 // path so no native file picker blocks the run.
 const pythonPath = process.env.JLAB_TEST_PYTHON_PATH;
 
-const LAB_URL = /https?:\/\/(127\.0\.0\.1|localhost):\d+/;
-
 // The welcome page renders a single unified "Open..." action on macOS and two
 // separate "Open File..." / "Open Folder..." actions elsewhere, so select the
 // link by platform. The macOS link drives the same showOpenDialog with both
@@ -31,10 +36,7 @@ const openFileLink =
     : '#open-file-link';
 
 test('New session opens a blank labview', async () => {
-  test.skip(
-    !pythonPath,
-    'set JLAB_TEST_PYTHON_PATH to a python with jupyterlab'
-  );
+  test.skip(!pythonPath, NEEDS_PYTHON);
   test.setTimeout(120000);
   const { app, userDataDir, jupyterDir } = await launchApp({ pythonPath });
   try {
@@ -51,10 +53,7 @@ test('New session opens a blank labview', async () => {
 });
 
 test('Open folder boots a session in the chosen directory', async () => {
-  test.skip(
-    !pythonPath,
-    'set JLAB_TEST_PYTHON_PATH to a python with jupyterlab'
-  );
+  test.skip(!pythonPath, NEEDS_PYTHON);
   test.setTimeout(120000);
   const projectDir = mkdtempSync(join(tmpdir(), 'jlab-e2e-project-'));
   const { app, userDataDir, jupyterDir } = await launchApp({ pythonPath });
@@ -79,10 +78,7 @@ test('Open folder boots a session in the chosen directory', async () => {
 });
 
 test('Open file boots a session for the chosen notebook', async () => {
-  test.skip(
-    !pythonPath,
-    'set JLAB_TEST_PYTHON_PATH to a python with jupyterlab'
-  );
+  test.skip(!pythonPath, NEEDS_PYTHON);
   test.setTimeout(120000);
   const projectDir = mkdtempSync(join(tmpdir(), 'jlab-e2e-project-'));
   const notebook = join(projectDir, 'opened.ipynb');