Skip to content

Commit 731a923

Browse files
committed
Fix tests
1 parent 16762f2 commit 731a923

File tree

1 file changed

+7
-1
lines changed

1 file changed

+7
-1
lines changed

tests/test_settings_api.py

+7-1
Original file line numberDiff line numberDiff line change
@@ -30,9 +30,13 @@ async def test_get_settings_overrides_dicts(jp_fetch, labserverapp):
3030

3131

3232
@pytest.mark.parametrize("ext", ["json", "json5"])
33-
async def test_get_settings_overrides_d_dicts(jp_fetch, labserverapp, ext):
33+
async def test_get_settings_overrides_d_dicts(
34+
jp_fetch, jp_serverapp, make_labserver_extension_app, ext
35+
):
3436
# Check that values that are dictionaries in overrides.d/*.json are
3537
# merged with the schema.
38+
labserverapp = make_labserver_extension_app()
39+
labserverapp._link_jupyter_server_extension(jp_serverapp)
3640
id = "@jupyterlab/apputils-extension:themes"
3741
overrides_d = Path(labserverapp.app_settings_dir) / "overrides.d"
3842
overrides_d.mkdir(exist_ok=True, parents=True)
@@ -41,6 +45,8 @@ async def test_get_settings_overrides_d_dicts(jp_fetch, labserverapp, ext):
4145
if ext == "json5":
4246
text += "\n// a comment"
4347
(overrides_d / f"foo-{i}.{ext}").write_text(text, encoding="utf-8")
48+
# Initialize labserverapp only after the overrides were created
49+
labserverapp.initialize()
4450
r = await jp_fetch("lab", "api", "settings", id)
4551
validate_request(r)
4652
res = r.body.decode()

0 commit comments

Comments
 (0)