Merge pull request #242 from fcollonval/ft/add-ci-lint-check

Add linter check in CI

Author: Steven Silvester

.github/workflows/tests.yml

@@ -37,6 +37,13 @@ jobs:
           npm install -g yarn
           yarn
 
+      - name: Check linters
+        if: ${{ matrix.os == 'ubuntu-latest' }}
+        shell: bash
+        run: |
+            set -eux
+            yarn lint:check
+
       - name: Build Source
         shell: bash
         run: |

.gitignore

@@ -28,3 +28,4 @@ docs/source/examples
 .vscode
 
 .jupyter_releaser_checkout
+.eslintcache

CONTRIBUTING.md

@@ -48,7 +48,7 @@ yarn test:examples
 
 ## Static Examples
 
-There are static examples built into the documentation.  Having them in docs allows us to test examples
+There are static examples built into the documentation. Having them in docs allows us to test examples
 in the ReadTheDocs build for a PR.
 
 To add an example to the static examples:

packages/datagrid/src/datagrid.ts

@@ -3709,7 +3709,12 @@ export class DataGrid extends Widget {
         const w = width;
         const h = contentHeight - Math.abs(dy);
         this._blitContent(this._canvas, x, y, w, h, x, y - dy);
-        this.paintContent(0, dy < 0 ? contentY : height - dy, width, Math.abs(dy));
+        this.paintContent(
+          0,
+          dy < 0 ? contentY : height - dy,
+          width,
+          Math.abs(dy)
+        );
       }
     }
 
@@ -3728,7 +3733,12 @@ export class DataGrid extends Widget {
         const w = contentWidth - Math.abs(dx);
         const h = height;
         this._blitContent(this._canvas, x, y, w, h, x - dx, y);
-        this.paintContent(dx < 0 ? contentX : width - dx, 0, Math.abs(dx), height);
+        this.paintContent(
+          dx < 0 ? contentX : width - dx,
+          0,
+          Math.abs(dx),
+          height
+        );
       }
     }
 
@@ -6435,11 +6445,13 @@ namespace Private {
    * @param region the paint region to be checked.
    * @returns boolean.
    */
-   export
-   function regionHasMergedCells(dataModel: DataModel, region: DataModel.CellRegion): boolean {
-     const regionGroups = CellGroup.getCellGroupsAtRegion(dataModel!, region);
-     return (regionGroups.length > 0);
-   }
+  export function regionHasMergedCells(
+    dataModel: DataModel,
+    region: DataModel.CellRegion
+  ): boolean {
+    const regionGroups = CellGroup.getCellGroupsAtRegion(dataModel!, region);
+    return regionGroups.length > 0;
+  }
 
   /**
    * An object which represents a region to be painted.