Skip to content

Commit 59e2b4d

Browse files
authored
Merge pull request #16 from krassowski/npm-namespace
Migrate to `@jupyterlab` npm namespace
2 parents 4589cfe + f808bbe commit 59e2b4d

9 files changed

Lines changed: 15 additions & 14 deletions

File tree

.github/workflows/build.yml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -37,7 +37,7 @@ jobs:
3737
python -m pip install .[test]
3838
3939
jupyter labextension list
40-
jupyter labextension list 2>&1 | grep -ie "@jupyterlab-benchmarks/ui-profiler.*OK"
40+
jupyter labextension list 2>&1 | grep -ie "@jupyterlab/ui-profiler.*OK"
4141
python -m jupyterlab.browser_check
4242
4343
- name: Package the extension
@@ -81,7 +81,7 @@ jobs:
8181
8282
8383
jupyter labextension list
84-
jupyter labextension list 2>&1 | grep -ie "@jupyterlab-benchmarks/ui-profiler.*OK"
84+
jupyter labextension list 2>&1 | grep -ie "@jupyterlab/ui-profiler.*OK"
8585
python -m jupyterlab.browser_check --no-chrome-test
8686
8787
integration-tests:

README.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -97,7 +97,7 @@ pip uninstall jupyterlab-ui-profiler
9797

9898
In development mode, you will also need to remove the symlink created by `jupyter labextension develop`
9999
command. To find its location, you can run `jupyter labextension list` to figure out where the `labextensions`
100-
folder is located. Then you can remove the symlink named `@jupyterlab-benchmarks/ui-profiler` within that folder.
100+
folder is located. Then you can remove the symlink named `@jupyterlab/ui-profiler` within that folder.
101101

102102
### Testing the extension
103103

jupyterlab_ui_profiler/__init__.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@
44
def _jupyter_labextension_paths():
55
return [{
66
"src": "labextension",
7-
"dest": "@jupyterlab-benchmarks/ui-profiler"
7+
"dest": "@jupyterlab/ui-profiler"
88
}]
99

1010

@@ -30,7 +30,7 @@ def _load_jupyter_server_extension(server_app):
3030
# Allow self-profiling in Chrome.
3131
"Document-Policy": "js-profiling"
3232
})
33-
name = "@jupyterlab-benchmarks/ui-profiler"
33+
name = "@jupyterlab/ui-profiler"
3434
server_app.log.info(f"Registered {name} server extension")
3535

3636

package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
{
2-
"name": "@jupyterlab-benchmarks/ui-profiler",
2+
"name": "@jupyterlab/ui-profiler",
33
"version": "0.1.4",
44
"description": "JupyterLab extension for profiling UI performance",
55
"keywords": [

pyproject.toml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -57,8 +57,8 @@ artifacts = ["jupyterlab_ui_profiler/labextension"]
5757
exclude = [".github", "binder"]
5858

5959
[tool.hatch.build.targets.wheel.shared-data]
60-
"jupyterlab_ui_profiler/labextension" = "share/jupyter/labextensions/@jupyterlab-benchmarks/ui-profiler"
61-
"install.json" = "share/jupyter/labextensions/@jupyterlab-benchmarks/ui-profiler/install.json"
60+
"jupyterlab_ui_profiler/labextension" = "share/jupyter/labextensions/@jupyterlab/ui-profiler"
61+
"install.json" = "share/jupyter/labextensions/@jupyterlab/ui-profiler/install.json"
6262
"jupyter-config/server-config" = "etc/jupyter/jupyter_server_config.d"
6363
"jupyter-config/nb-config" = "etc/jupyter/jupyter_notebook_config.d"
6464

src/__tests__/jupyterlab-ui-profiler.spec.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@
22
* Example of [Jest](https://jestjs.io/docs/getting-started) unit tests
33
*/
44

5-
describe('@jupyterlab-benchmarks/ui-profiler', () => {
5+
describe('@jupyterlab/ui-profiler', () => {
66
it('should be tested', () => {
77
expect(1 + 1).toEqual(2);
88
});

src/index.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -41,10 +41,10 @@ namespace CommandIDs {
4141
}
4242

4343
/**
44-
* Initialization data for the @jupyterlab-benchmarks/ui-profiler extension.
44+
* Initialization data for the @jupyterlab/ui-profiler extension.
4545
*/
4646
const plugin: JupyterFrontEndPlugin<void> = {
47-
id: '@jupyterlab-benchmarks/ui-profiler:plugin',
47+
id: '@jupyterlab/ui-profiler:plugin',
4848
autoStart: true,
4949
requires: [IFileBrowserFactory],
5050
optional: [ILauncher, ILayoutRestorer],

src/ui.tsx

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -482,7 +482,8 @@ export function renderProfile(props: {
482482
typeof timing.resource === 'undefined' && timing.name === 'Profiler';
483483
const isOurProfilerCode =
484484
timing.resource &&
485-
timing.resource.includes('@jupyterlab-benchmarks/ui-profiler');
485+
(timing.resource.includes('@jupyterlab-benchmarks/ui-profiler') ||
486+
timing.resource.includes('@jupyterlab/ui-profiler'));
486487
return !isNativeProfilerCall && !isOurProfilerCode;
487488
}
488489
);

ui-tests/package.json

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
{
2-
"name": "@jupyterlab-benchmarks/ui-profiler-ui-tests",
2+
"name": "@jupyterlab/ui-profiler-ui-tests",
33
"version": "1.0.0",
4-
"description": "JupyterLab @jupyterlab-benchmarks/ui-profiler Integration Tests",
4+
"description": "JupyterLab @jupyterlab/ui-profiler Integration Tests",
55
"private": true,
66
"scripts": {
77
"start": "jupyter lab --config jupyter_server_test_config.py",

0 commit comments

Comments
 (0)