-
Notifications
You must be signed in to change notification settings - Fork 21
Open
Labels
good first issueGood for newcomersGood for newcomershacktoberfestIssues that are up for grabs for hacktoberfest participantsIssues that are up for grabs for hacktoberfest participants
Description
Ensure all ReScript modules follow community naming conventions:
- PascalCase for modules and types
- camelCase for functions and variables
- SCREAMING_SNAKE_CASE for constants
Current violations found:
- Type names using lowercase (should be PascalCase)
File: src/types/LoggerTypes.res:1
type logType = DEBUG | INFO | ERROR | WARNING
Should be:
type LogType = DEBUG | INFO | ERROR | WARNING
File: src/types/LoggerTypes.res:2
type logCategory = API | USER_ERROR | USER_EVENT | MERCHANT_EVENT
Should be:
type LogCategory = API | USER_ERROR | USER_EVENT | MERCHANT_EVENT
File: src/types/LoggerTypes.res:3
type logComponent = MOBILE
Should be:
type LogComponent = MOBILE
- Functions using snake_case (should be camelCase)
File: src/hooks/ThemebasedStyle.res
let status_color = {
Should be:
let statusColor = {
File: src/icons/Icon.res
let google_pay = <svg...
Should be:
let googlePay = <svg...
Files to check and fix:
- src/types/LoggerTypes.res - Multiple type names
- src/types/SamsungPayType.res - Type names like payment3DS,
addressType - src/hooks/ThemebasedStyle.res - Function status_color
- src/icons/Icon.res - Function google_pay
Acceptance Criteria:
- All type names use PascalCase
- All function and variable names use camelCase
- Constants use SCREAMING_SNAKE_CASE (if any exist)
- Code compiles successfully after changes
- All tests pass
- NO flows should be effected
Metadata
Metadata
Assignees
Labels
good first issueGood for newcomersGood for newcomershacktoberfestIssues that are up for grabs for hacktoberfest participantsIssues that are up for grabs for hacktoberfest participants