Skip to content

[REFACTOR] Move Hardcoded Value to Constant for Max Invitations #5938

@ThisIsMani

Description

@ThisIsMani

Feature Description

Here:

if requests.len() > 10 {

In the current implementation, the value 10 is hardcoded when checking the number of invite requests in the code. To improve maintainability and avoid magic numbers, this value should be moved to a constant in crates/router/src/consts/user.rs.

Possible Implementation

  • Create a new constant in crates/router/src/consts/user.rs to represent the maximum number of allowed invite requests.
  • Refactor the code to replace the hardcoded value 10 with this new constant.

Have you spent some time checking if this feature request has been raised before?

  • I checked and didn't find a similar issue

Submission Process:

  • Ask the maintainers for assignment of the issue, you can request for assignment by commenting on the issue itself.
  • Once assigned, submit a pull request (PR).
  • Maintainers will review and provide feedback, if any.
  • Maintainers can unassign issues due to inactivity, read more here.

Refer here for Terms and conditions for the contest.

Metadata

Metadata

Assignees

Labels

A-usersArea: UsersC-refactorCategory: Refactorgood first issueGood for newcomershacktoberfestIssues that are up for grabs for Hacktoberfest participants

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions