Skip to content

refactor(connector): add amount conversion framework to Square #6566

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

refactor(connector): add amount conversion framework to Square #6566

wants to merge 2 commits into from

Conversation

mrswastik-robot
Copy link

@mrswastik-robot mrswastik-robot commented Nov 13, 2024 •
edited
Loading

Type of Change

  • Bugfix
  • New feature
  • Enhancement
  • Refactoring
  • Dependency updates
  • Documentation
  • CI/CD

Description

This PR adds amount conversion framework to Square for sending to connector.
Square accepts amount in MinorUnit.
Resolves #6137

Additional Changes

  • This PR modifies the API contract
  • This PR modifies the database schema
  • This PR modifies application configuration/environment variables

Motivation and Context

How did you test it?

Tests passed on cargo test --all-features
No errors on cargo check --all-features

Checklist

  • I formatted the code cargo +nightly fmt --all
  • I addressed lints thrown by cargo clippy
  • I reviewed the submitted code
  • I added unit tests for my changes where possible

@mrswastik-robot mrswastik-robot requested review from a team as code owners November 13, 2024 22:50
@semanticdiff-com SemanticDiff.com
Copy link

semanticdiff-com bot commented Nov 13, 2024 •
edited
Loading

Review changes with  SemanticDiff

Changed Files
File Status
  crates/router/src/types/api.rs  72% smaller
  crates/router/tests/connectors/square.rs  62% smaller
  crates/hyperswitch_connectors/src/connectors/square/transformers.rs  44% smaller
  crates/hyperswitch_connectors/src/connectors/square.rs  33% smaller

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[REFACTOR]: [SQUARE] Add amount conversion framework to Square
1 participant
@mrswastik-robot