Skip to content

[Refactor]: [ACI] reuse utility functions from connector utils #7927

Open
@AkshayaFoiger

Description

@AkshayaFoiger

Refactor Description

  • In Hyperswitch, reusable and connector-agnostic functions used in connector integrations are added to crates/hyperswitch_connectors/src/utils.rs.

However, parts of the current ACI integration reimplement these functions instead of reusing them.

Possible Implementation

  1. Review transformer.rs in the ACI connector to identify opportunities to reuse functions from crates/hyperswitch_connectors/src/utils.rs .

  2. Replace the existing implementations with the corresponding reusable functions from the utils module where applicable.

Example

Current - shopper_result_url: item.router_data.request.router_return_url.clone(),
Expected - shopper_result_url: item.router_data.request.get_router_return_url().ok(),

Have you spent some time checking if this feature request has been raised before?

  • I checked and didn't find a similar issue

Have you read the Contributing Guidelines?

Are you willing to submit a PR?

None

Metadata

Metadata

Assignees

No one assigned

    Labels

    A-connector-integrationArea: Connector integrationC-refactorCategory: RefactorE-easyEffort: Should be easy to implement and would make a good first PRS-awaiting-triageStatus: New issues that have not been assessed yetgood first issueGood for newcomers

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions