-
Notifications
You must be signed in to change notification settings - Fork 4.4k
Labels
RustPull requests that update Rust codePull requests that update Rust codeS-unassignedStatus: This issue has no one assigned to address itStatus: This issue has no one assigned to address itgood first issueGood for newcomersGood for newcomershacktoberfestIssues that are up for grabs for Hacktoberfest participantsIssues that are up for grabs for Hacktoberfest participants
Description
Feature Description/Summary
Shift4 is a global payments platform that allows merchants to process transactions across multiple payment methods. In the current Hyperswitch integration with Shift4, while attempting to process payments using the sofort payment method, the connector API responds with an error that the payment method is not supported.
Context
While running authorization flows in Hyperswitch using the Shift4 connector, the following error is consistently observed:
ErrorResponse { error: ApiErrorResponse { code: None, message: "Payment method type sofort not supported" } }
Starter Tasks
- Go ahead to the connector documentation and check if the connector (Shift4) even supports Sofort.
- Check the request and response schemas for Sofort in Shift4 and if there exists any disparity between the documentation and hyperswitch's integration, fix that issue.
- Check in all the config files that the particular country currency mentioned for Shift4's Sofort Payment Method is correct or not.
- If at all the connector doesn't support sofort then, in the list of SupportedPaymentMethods, remove Sofort.
Implementation Hints
- You can go to
crates/hyperswitch_connectors/src/connectors/shift4.rs
andcrates/hyperswitch_connectors/src/connectors/shift4/transformers.rs
and make relevant changes according to what's gone in the current integration. - Head to this documentation to get some clarity about the request and response schemas : URL
Acceptance Criteria
- Request and Response body added for each of the flows where integrity check is applied.
- All the required GitHub checks passing
- Formatted the code using
cargo +nightly fmt --all
How to Test it
- Create a Merchant Account in local
- Create an API Key
- Add the connector - Shift4
- Test out the flows
Mentor Contact
- Tag @bsayak03 [Sayak Bhattacharya] in the comments if you have any doubts/queries
Resources
Here is the connector documentation link : URL
Pre-Flight
Have you spent some time checking if this feature request has been raised before?
- I checked and didn't find a similar issue
Have you read the Contributing Guidelines?
- I have read the Contributing Guidelines
Submission Process:
- Ask the maintainers for assignment of the issue, you can request for assignment by commenting on the issue itself.
- Once assigned, submit a pull request (PR).
- Maintainers will review and provide feedback, if any.
- Maintainers can unassign issues due to inactivity, read more here.
Refer here for Terms and conditions for the contest.
Metadata
Metadata
Assignees
Labels
RustPull requests that update Rust codePull requests that update Rust codeS-unassignedStatus: This issue has no one assigned to address itStatus: This issue has no one assigned to address itgood first issueGood for newcomersGood for newcomershacktoberfestIssues that are up for grabs for Hacktoberfest participantsIssues that are up for grabs for Hacktoberfest participants