Add tests for crossorigin

indykoning · indykoning · commit 7355e4c81f1c · 2024-11-06T16:51:30.000+01:00
diff --git a/src/Listeners/AddFromBody.php b/src/Listeners/AddFromBody.php
@@ -22,7 +22,7 @@ public function handle(GenerateEarlyHints $event)
                 [$src, $href, $data, $rel, $type, $crossorigin, $as, $fetchpriority, $integrity, $referrerpolicy, $imagesizes, $imagesrcset] = $element;
                 $rel = $type === 'module' ? 'modulepreload' : $rel;
 
-                if ($rel === 'modulepreload' && ! $crossorigin) {
+                if ($rel === 'modulepreload' && empty($crossorigin)) {
                     // On module or modulepreload the crossorigin is REQUIRED https://github.com/whatwg/html/issues/1888
                     $crossorigin = 'anonymous';
                 }
diff --git a/tests/AddHttp3EarlyHintsTest.php b/tests/AddHttp3EarlyHintsTest.php
@@ -78,6 +78,30 @@ public function it_will_return_a_js_link_header_for_js()
         $this->assertStringEndsWith('as="script"', $response->headers->get('link'));
     }
 
+    /** @test */
+    public function it_will_return_a_js_link_header_with_crossorigin_for_js_module()
+    {
+        $request = $this->getNewRequest();
+
+        $response = $this->middleware->handle($request, $this->getNext('pageWithJsModule'));
+
+        $this->assertTrue($this->isServerPushResponse($response));
+        $this->assertStringEndsWith('as="script"', $response->headers->get('link'));
+        $this->assertStringContainsString('crossorigin="anonymous"', $response->headers->get('link'));
+    }
+
+    /** @test */
+    public function it_will_return_a_js_link_header_with_use_credentials_crossorigin_for_js_module()
+    {
+        $request = $this->getNewRequest();
+
+        $response = $this->middleware->handle($request, $this->getNext('pageWithJsCrossoriginModule'));
+
+        $this->assertTrue($this->isServerPushResponse($response));
+        $this->assertStringEndsWith('as="script"', $response->headers->get('link'));
+        $this->assertStringContainsString('crossorigin="use-credentials"', $response->headers->get('link'));
+    }
+
     /** @test */
     public function it_will_return_an_image_link_header_for_images()
     {
diff --git a/tests/fixtures/pageWithJsCrossoriginModule.html b/tests/fixtures/pageWithJsCrossoriginModule.html
@@ -0,0 +1,11 @@
+<html>
+
+    <head>
+        <title>Page title</title>
+    </head>
+
+    <body>
+        <script type="module" src="js/module.js" crossorigin="use-credentials"></script>
+    </body>
+
+</html>
diff --git a/tests/fixtures/pageWithJsModule.html b/tests/fixtures/pageWithJsModule.html
@@ -0,0 +1,11 @@
+<html>
+
+    <head>
+        <title>Page title</title>
+    </head>
+
+    <body>
+        <script type="module" src="js/module.js"></script>
+    </body>
+
+</html>

Original file line number	Diff line number	Diff line change
`@@ -22,7 +22,7 @@ public function handle(GenerateEarlyHints $event)`
`22`	`22`	`[$src, $href, $data, $rel, $type, $crossorigin, $as, $fetchpriority, $integrity, $referrerpolicy, $imagesizes, $imagesrcset] = $element;`
`23`	`23`	`$rel = $type === 'module' ? 'modulepreload' : $rel;`
`24`	`24`
`25`		`- if ($rel === 'modulepreload' && ! $crossorigin) {`
	`25`	`+ if ($rel === 'modulepreload' && empty($crossorigin)) {`
`26`	`26`	`// On module or modulepreload the crossorigin is REQUIRED https://github.com/whatwg/html/issues/1888`
`27`	`27`	`$crossorigin = 'anonymous';`
`28`	`28`	`}`
-Original file line number
+Diff line change
@@ @@ -0,0 +1,11 @@ @@
 +<html>
++
 +    <head>
 +        <title>Page title</title>
 +    </head>
++
 +    <body>
 +        <script type="module" src="js/module.js" crossorigin="use-credentials"></script>
 +    </body>
++
 +</html>