Skip to content

Commit 76f012e

Browse files
authored
Correct types of symfony responses
1 parent 1b7a08b commit 76f012e

File tree

1 file changed

+6
-6
lines changed

1 file changed

+6
-6
lines changed

src/Middleware/AddHttp3EarlyHints.php

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -80,12 +80,12 @@ public function handle(Request $request, Closure $next, ?int $limit = null, ?int
8080
/**
8181
* We only start crawling once the response has already been sent to the client in order to reduce impact on performance.
8282
*/
83-
public function terminate(Request $request, \Symfony\Component\HttpFoundation\Response $response): void
83+
public function terminate(Request $request, SymfonyResponse $response): void
8484
{
8585
$this->handleGeneratingLinkHeaders($request, $response);
8686
}
8787

88-
public function handleGeneratingLinkHeaders(Request $request, \Symfony\Component\HttpFoundation\Response $response)
88+
public function handleGeneratingLinkHeaders(Request $request, SymfonyResponse $response)
8989
{
9090
if (
9191
! $response instanceof Response
@@ -115,7 +115,7 @@ public function getConfig(mixed $key, mixed $default = false): mixed
115115
return config('http3earlyhints.'.$key, $default);
116116
}
117117

118-
protected function generateLinkHeaders(Response $response, ?int $limit = null, ?int $sizeLimit = null, ?array $excludeKeywords = null): Collection
118+
protected function generateLinkHeaders(SymfonyResponse $response, ?int $limit = null, ?int $sizeLimit = null, ?array $excludeKeywords = null): Collection
119119
{
120120
$excludeKeywords = array_filter($excludeKeywords ?? $this->getConfig('exclude_keywords', []));
121121
$headers = $this->fetchLinkableNodes($response)
@@ -159,15 +159,15 @@ protected function generateLinkHeaders(Response $response, ?int $limit = null, ?
159159
/**
160160
* Get the DomCrawler instance.
161161
*/
162-
protected function getCrawler(Response $response): Crawler
162+
protected function getCrawler(SymfonyResponse $response): Crawler
163163
{
164164
return $this->crawler ??= new Crawler($response->getContent());
165165
}
166166

167167
/**
168168
* Get all nodes we are interested in pushing.
169169
*/
170-
protected function fetchLinkableNodes(Response $response): Collection
170+
protected function fetchLinkableNodes(SymfonyResponse $response): Collection
171171
{
172172
$crawler = $this->getCrawler($response);
173173

@@ -221,7 +221,7 @@ private function buildLinkHeaderString(string $url, ?string $rel = 'preload'): ?
221221
/**
222222
* Add Link Header
223223
*/
224-
private function addLinkHeader(\Symfony\Component\HttpFoundation\Response $response, mixed $link): Response
224+
private function addLinkHeader(SymfonyResponse $response, mixed $link): SymfonyResponse
225225
{
226226
$link = trim(collect($link)->implode(','));
227227
if (! $link || !$response instanceof Response) {

0 commit comments

Comments
 (0)