SCA

Author: VincentBean

src/OAuth/KeyStore/DatabaseKeyStore.php

@@ -11,7 +11,7 @@ public function get(string $connection): array
         /** @var ?OAuthKey $key */
         $key = OAuthKey::query()->firstWhere('magento_connection', '=', $connection);
 
-        return $key?->keys ?? [];
+        return $key->keys ?? [];
     }
 
     public function set(string $connection, array $data): void

src/OAuth/MagentoServer.php

@@ -48,7 +48,7 @@ protected function createTemporaryCredentials($body): TemporaryCredentials
     {
         parse_str($body, $data);
 
-        if (! $data || ! is_array($data)) {
+        if (! $data ) {
             throw new CredentialsException('Unable to parse temporary credentials response.');
         }
 
@@ -80,13 +80,13 @@ public function userUid($data, TokenCredentials $tokenCredentials): int
         return 0;
     }
 
-    public function userEmail($data, TokenCredentials $tokenCredentials)
+    public function userEmail($data, TokenCredentials $tokenCredentials): ?string
     {
-        //
+        return null;
     }
 
-    public function userScreenName($data, TokenCredentials $tokenCredentials)
+    public function userScreenName($data, TokenCredentials $tokenCredentials): ?string
     {
-        //
+        return null;
     }
 }

tests/OAuth/KeyStore/FileKeyStoreTest.php

@@ -28,7 +28,7 @@ public function it_can_get_data(): void
         /** @var FileKeyStore $store */
         $store = KeyStore::instance();
 
-        /** @var string $encoded */
+        /** @var non-empty-string $encoded */
         $encoded = json_encode($content);
 
         Storage::disk($store->disk)->put($store->path.'/default.json', $encoded);
@@ -61,7 +61,7 @@ public function it_can_merge_data(): void
             'key' => 'value',
         ];
 
-        /** @var string $encoded */
+        /** @var non-empty-string $encoded */
         $encoded = json_encode($content);
 
         /** @var FileKeyStore $store */