Merge pull request #35 from justbetter/feature/bulk-stale

Bulk operations stale

Author: VincentBean

config/magento-stock.php

@@ -11,4 +11,7 @@
 
     /* Send stock updates using Magento 2's async endpoints, a configured message queue in Magento is required for this */
     'async' => false,
+
+    /* Number of hours before async bulk operations are considered stale and prices can be re-queued */
+    'async_stale_hours' => 24,
 ];

src/Actions/ProcessStocks.php

@@ -41,9 +41,16 @@ public function process(): void
                     $query->where('exists_in_magento', '=', true);
                 })
                 ->whereDoesntHave('bulkOperations', function (Builder $query): void {
+                    $staleHours = config()->integer('magento-stock.async_stale_hours', 24);
+                    $staleThreshold = now()->subHours($staleHours);
+
                     $query
-                        ->where('status', '=', OperationStatus::Open)
-                        ->orWhereNull('status');
+                        ->where(function (Builder $query): void {
+                            $query
+                                ->where('status', '=', OperationStatus::Open)
+                                ->orWhereNull('status');
+                        })
+                        ->where('created_at', '>=', $staleThreshold);
                 })
                 ->select(['id', 'sku'])
                 ->take($repository->updateLimit())

tests/Actions/ProcessStocksTest.php

@@ -98,6 +98,7 @@ public function it_does_not_dispatch_stocks_with_open_async_operations(): void
         $stock = Stock::query()->create([
             'sku' => '::sku_1::',
             'update' => true,
+            'created_at' => now()->subMinutes(10),
         ]);
 
         /** @var BulkRequest $request */
@@ -137,6 +138,57 @@ public function it_does_not_dispatch_stocks_with_open_async_operations(): void
         });
     }
 
+    #[Test]
+    public function it_dispatches_stocks_with_stale_async_operations(): void
+    {
+        Bus::fake();
+        config()->set('magento-stock.async', true);
+        config()->set('magento-stock.async_stale_hours', 24);
+
+        MagentoProduct::query()->create([
+            'sku' => '::sku::',
+            'exists_in_magento' => true,
+        ]);
+
+        /** @var Stock $stock */
+        $stock = Stock::query()->create([
+            'sku' => '::sku::',
+            'update' => true,
+        ]);
+
+        /** @var BulkRequest $request */
+        $request = BulkRequest::query()->create([
+            'magento_connection' => '::magento-connection::',
+            'store_code' => '::store-code::',
+            'method' => 'POST',
+            'path' => '::path::',
+            'bulk_uuid' => '::bulk-uuid::',
+            'request' => [
+                [
+                    'call-1',
+                ],
+            ],
+            'response' => [],
+            'created_at' => now()->subHours(25),
+        ]);
+
+        $request->operations()->create([
+            'operation_id' => 0,
+            'subject_type' => $stock->getMorphClass(),
+            'subject_id' => $stock->getKey(),
+            'status' => OperationStatus::Open,
+            'created_at' => now()->subHours(25),
+        ]);
+
+        /** @var ProcessStocks $action */
+        $action = app(ProcessStocks::class);
+        $action->process();
+
+        Bus::assertDispatched(UpdateStockAsyncJob::class, function (UpdateStockAsyncJob $job): bool {
+            return $job->stocks->count() === 1 && $job->stocks->first()?->sku === '::sku::';
+        });
+    }
+
     #[Test]
     public function it_does_not_dispatch_update_jobs_if_magento_is_unavailable(): void
     {