Merge pull request #23 from justbetter/feature/compare-only-existing

Only compare products that exist in Magento

Author: VincentBean

src/Jobs/Comparison/DispatchComparisonsJob.php

@@ -5,6 +5,7 @@
 use Illuminate\Bus\Queueable;
 use Illuminate\Contracts\Queue\ShouldBeUnique;
 use Illuminate\Contracts\Queue\ShouldQueue;
+use Illuminate\Database\Eloquent\Builder;
 use Illuminate\Foundation\Bus\Dispatchable;
 use Illuminate\Queue\InteractsWithQueue;
 use Illuminate\Support\Facades\Bus;
@@ -24,6 +25,9 @@ public function __construct()
     public function handle(): void
     {
         $batch = Stock::query()
+            ->whereHas('product', function (Builder $query): void {
+                $query->where('exists_in_magento', '=', true);
+            })
             ->get()
             ->mapInto(CompareStockJob::class);
 

src/Models/Stock.php

@@ -28,6 +28,7 @@
  * @property string $checksum
  * @property int $fail_count
  * @property ?Carbon $last_failed
+ * @property ?MagentoProduct $product
  */
 class Stock extends Model
 {

tests/Jobs/Comparison/DispatchComparisonsJobTest.php

@@ -4,6 +4,7 @@
 
 use Illuminate\Support\Facades\Bus;
 use Illuminate\Support\Testing\Fakes\PendingBatchFake;
+use JustBetter\MagentoProducts\Models\MagentoProduct;
 use JustBetter\MagentoStock\Jobs\Comparison\CompareStockJob;
 use JustBetter\MagentoStock\Jobs\Comparison\DispatchComparisonsJob;
 use JustBetter\MagentoStock\Models\Stock;
@@ -18,7 +19,16 @@ public function it_dispatches_comparisons(): void
         Bus::fake([CompareStockJob::class]);
 
         Stock::query()->create([
-            'sku' => '::sku::',
+            'sku' => '::sku_1::',
+        ]);
+
+        Stock::query()->create([
+            'sku' => '::sku_2::',
+        ]);
+
+        MagentoProduct::query()->create([
+            'sku' => '::sku_1::',
+            'exists_in_magento' => true,
         ]);
 
         DispatchComparisonsJob::dispatch();