Merge pull request #25 from justbetter/feature/enumerable-skus

Enumerable skus instead of Collection

Author: VincentBean

README.md

@@ -126,11 +126,11 @@ namespace App\Integrations\MagentoStock;
 
 use JustBetter\MagentoStock\Repositories\Repository;
 use Illuminate\Support\Carbon;
-use Illuminate\Support\Collection;
+use Illuminate\Support\Enumerable;
 
 class MyStockRepository extends Repository
 {
-    public function skus(?Carbon $from = null): ?Collection
+    public function skus(?Carbon $from = null): ?Enumerable
     {
         return collect(['sku_1', 'sku_2']);
     }

src/Repositories/BaseRepository.php

@@ -3,7 +3,7 @@
 namespace JustBetter\MagentoStock\Repositories;
 
 use Illuminate\Support\Carbon;
-use Illuminate\Support\Collection;
+use Illuminate\Support\Enumerable;
 use JustBetter\MagentoStock\Data\StockData;
 
 abstract class BaseRepository
@@ -63,8 +63,8 @@ public static function resolve(): BaseRepository
         return $instance;
     }
 
-    /** @return Collection<int, string> */
-    abstract public function skus(?Carbon $from = null): Collection;
+    /** @return Enumerable<int, string> */
+    abstract public function skus(?Carbon $from = null): Enumerable;
 
     abstract public function retrieve(string $sku): ?StockData;
 }

src/Repositories/Repository.php

@@ -3,7 +3,7 @@
 namespace JustBetter\MagentoStock\Repositories;
 
 use Illuminate\Support\Carbon;
-use Illuminate\Support\Collection;
+use Illuminate\Support\Enumerable;
 use JustBetter\MagentoProducts\Models\MagentoProduct;
 use JustBetter\MagentoStock\Data\StockData;
 use JustBetter\MagentoStock\Exceptions\NotImplementedException;
@@ -15,9 +15,9 @@ public function retrieve(string $sku): ?StockData
         throw new NotImplementedException;
     }
 
-    public function skus(?Carbon $from = null): Collection
+    public function skus(?Carbon $from = null): Enumerable
     {
-        /** @var Collection<int, string> $skus */
+        /** @var Enumerable<int, string> $skus */
         $skus = MagentoProduct::query()
             ->where('exists_in_magento', '=', true)
             ->select(['sku'])