Fix: update $storeId type hints to int|string|null in SlackHelper

claudio-ferraro · web-flow · commit 18b41959d9cd · 2025-11-13T15:39:50.000+01:00
Changed the $storeId parameters in Helper/SlackHelper.php from ?int to int|string|null to ensure full compatibility with Magento's ScopeConfigInterface.
diff --git a/Helper/SlackHelper.php b/Helper/SlackHelper.php
@@ -14,7 +14,7 @@ class SlackHelper extends AbstractHelper
      * @param  String $field
      * @param  Int $storeId
      */
-    public function getConfigValue($field, ?int $storeId = null)
+    public function getConfigValue($field, int|string|null $storeId = null)
     {
         return $this->scopeConfig->getValue(
             $field,
@@ -28,7 +28,7 @@ public function getConfigValue($field, ?int $storeId = null)
      * @param  String $code
      * @param  null $storeId
      */
-    public function getGeneralConfig($code, ?int $storeId = null)
+    public function getGeneralConfig($code, int|string|null $storeId = null)
     {
         return $this->getConfigValue(self::XML_PATH . $code, $storeId);
     }

Original file line number	Diff line number	Diff line change
`@@ -14,7 +14,7 @@ class SlackHelper extends AbstractHelper`
`14`	`14`	`* @param String $field`
`15`	`15`	`* @param Int $storeId`
`16`	`16`	`*/`
`17`		`- public function getConfigValue($field, ?int $storeId = null)`
	`17`	`+ public function getConfigValue($field, int\|string\|null $storeId = null)`
`18`	`18`	`{`
`19`	`19`	`return $this->scopeConfig->getValue(`
`20`	`20`	`$field,`
`@@ -28,7 +28,7 @@ public function getConfigValue($field, ?int $storeId = null)`
`28`	`28`	`* @param String $code`
`29`	`29`	`* @param null $storeId`
`30`	`30`	`*/`
`31`		`- public function getGeneralConfig($code, ?int $storeId = null)`
	`31`	`+ public function getGeneralConfig($code, int\|string\|null $storeId = null)`
`32`	`32`	`{`
`33`	`33`	`return $this->getConfigValue(self::XML_PATH . $code, $storeId);`
`34`	`34`	`}`