Remove redundant eav via observer after product import is finished + add config

Author: claudio-ferraro

Plugin/RemoveRedundantEav.php Observer/RemoveRedundantEav.phpPlugin/RemoveRedundantEav.php renamed to Observer/RemoveRedundantEav.php

@@ -1,31 +1,34 @@
 <?php
 
-namespace JustBetter\AkeneoBundle\Plugin;
+namespace JustBetter\AkeneoBundle\Observer;
 
 use Akeneo\Connector\Executor\JobExecutor;
 use Akeneo\Connector\Helper\Import\Entities;
 use Akeneo\Connector\Helper\Output;
 use Magento\Framework\App\ResourceConnection;
+use Magento\Framework\Event\Observer;
+use Magento\Framework\Event\ObserverInterface;
+use Magento\Framework\App\Config\ScopeConfigInterface;
 
-class RemoveRedundantEav
+class RemoveRedundantEav implements ObserverInterface
 {
     public const CATALOG_PRODUCT_ENTITY_DATA_TYPES = ['int', 'text', 'decimal', 'gallery', 'varchar', 'datetime'];
 
     public function __construct(
         protected Entities $entities,
         protected ResourceConnection $resourceConnection,
+        protected Output $outputHelper,
         protected JobExecutor $jobExecutor,
-        protected Output $outputHelper
+        protected ScopeConfigInterface $scopeConfig
     ) {
     }
 
-    public function beforeRefreshIndex(): void
+    public function execute(Observer $observer): void
     {
-        self::removeRedundantEAV();
-    }
+        if (!$this->scopeConfig->isSetFlag('akeneo_connector/justbetter/remove_redundant_eav')) {
+            return;
+        }
 
-    public function removeRedundantEAV(): void
-    {
         $this->jobExecutor->displayInfo((string)$this->outputHelper->getPrefix() . __('Remove Redundant EAV attribute values'));
         $connection = $this->resourceConnection->getConnection();
 
@@ -44,4 +47,4 @@ public function removeRedundantEAV(): void
             $connection->query($query);
         }
     }
-}
+}

etc/adminhtml/system.xml

@@ -138,6 +138,11 @@
                         <field id="akeneo_connector/justbetter/defaultstorevalues">1</field>
                     </depends>
                 </field>
+                <field id="remove_redundant_eav" translate="label" type="select" sortOrder="160" showInDefault="1" showInWebsite="0" showInStore="0">
+                    <label>Remove Redundant EAV</label>
+                    <source_model>Magento\Config\Model\Config\Source\Yesno</source_model>
+                    <comment>Enable or disable the removal of redundant EAV attribute values. (Default: no)</comment>
+                </field>
                 <group id="slack" translate="label" type="text" sortOrder="160" showInDefault="1" showInWebsite="0"
                        showInStore="0">
                     <label>Slack Akeneo import notifications</label>

etc/di.xml

@@ -9,7 +9,6 @@
         <plugin name="JustBetter_SetStockStatus" type="JustBetter\AkeneoBundle\Plugin\SetStockStatus" sortOrder="2" />
         <plugin name="JustBetter_ImportFinished" type="JustBetter\AkeneoBundle\Plugin\ImportFinished" sortOrder="10" />
         <plugin name="JustBetter_CheckWebsiteAssociation" type="JustBetter\AkeneoBundle\Plugin\CheckWebsiteAssociation" />
-        <plugin name="JustBetter_RemoveRedundantEav" type="JustBetter\AkeneoBundle\Plugin\RemoveRedundantEav" />
     </type>
 
     <type name="Akeneo\Connector\Job\Category">

etc/events.xml

@@ -4,5 +4,6 @@
     </event>
     <event name="akeneo_connector_import_finish_product">
         <observer name="set_not_visible" instance="JustBetter\AkeneoBundle\Observer\SetNotVisible"/>
+        <observer name="remove_redundant_eav" instance="JustBetter\AkeneoBundle\Observer\RemoveRedundantEav" />
     </event>
 </config>