Merge pull request #3 from Jade-GG

Replace null strings with empty strings & fix wrong locale function

Author: BobWez98

src/Translators/DeeplTranslator.php

@@ -23,9 +23,15 @@ public function translate(Entry $source, Collection $localisableFields, Site $si
         });
 
         $keys = $dotted->keys()->values();
-        $texts = $dotted->values()->all();
+        $texts = $dotted->values()
+            ->map(fn ($text) => $text ?? '')
+            ->all();
 
-        $results = $deeplClient->translateText($texts, $source->locale(), $this->mapLanguageForDeepL((string) $site->shortLocale()));
+        $results = $deeplClient->translateText(
+            $texts,
+            $this->mapLanguageForDeepL((string) $source->site()->shortLocale()),
+            $this->mapLanguageForDeepL((string) $site->shortLocale())
+        );
 
         $translatedTexts = collect($results)
             ->map(fn ($result) => $result->text)

tests/Translators/DeeplTranslatorTest.php

@@ -39,7 +39,7 @@ public function it_translates_data(): void
                 ->once()
                 ->with(
                     ['foo'],
-                    'en',
+                    'en-US',
                     'en-US'
                 )->andReturn([(object) ['text' => 'bar']]);
         });