Fix nullable reference type warnings

Author: justcoding121

src/Bible.Alarm/Platforms/Android/Services/UI/NotificationService.cs

@@ -18,7 +18,7 @@
 
 namespace Bible.Alarm.Platforms.Android.Services.UI;
 
-public class DroidNotificationService(ILogger logger, IStorageService storageService) : INotificationService
+public class DroidNotificationService(ILogger logger, IStorageService _) : INotificationService
 {
     public static readonly string ChannelIdAndName = "alarm_notification";
     public static readonly string ChannelDescription = "alarm_notification are send to this channel";
@@ -186,7 +186,7 @@ private bool IsAndroidService()
 
     public void Dispose()
     {
-        // Note: storageService (IStorageService) is a singleton
-        // and should not be disposed here as it is managed by the DI container
+        // Note: IStorageService parameter is intentionally unused but required for DI
+        // It is a singleton and should not be disposed here as it is managed by the DI container
     }
 }

src/Bible.Alarm/ViewModels/Bible/BibleSelectionViewModel.cs

@@ -56,8 +56,8 @@ public BibleSelectionViewModel(MediaService mediaService, INavigationService nav
         _subscriptions.Add(subscription1);
 
         // Subscribe to subsequent schedule changes (skip first one)
-        BibleReadingSchedule? lastCurrent = null;
-        BibleReadingSchedule? lastTentative = null;
+        BibleReadingSchedule lastCurrent = null;
+        BibleReadingSchedule lastTentative = null;
         var subscription2 = ReduxContainer.Store.Subscribe(state =>
         {
             if (state.CurrentBibleReadingSchedule != null && state.TentativeBibleReadingSchedule != null

src/Bible.Alarm/ViewModels/Bible/BookSelectionViewModel.cs

@@ -77,7 +77,7 @@ public BookSelectionViewModel(MediaService mediaService, INavigationService navi
         });
 
         // Subscribe to current schedule changes (but skip first one)
-        BibleReadingSchedule? lastCurrent = null;
+        BibleReadingSchedule lastCurrent = null;
         var subscription2 = ReduxContainer.Store.Subscribe(state =>
         {
             if (state.CurrentBibleReadingSchedule != null && state.CurrentBibleReadingSchedule != lastCurrent)

src/Bible.Alarm/ViewModels/Music/SongBookSelectionViewModel.cs

@@ -50,8 +50,8 @@ public SongBookSelectionViewModel(MediaService mediaService, INavigationService
         _subscriptions.Add(subscription1);
 
         // Subscribe to subsequent music changes (skip first one)
-        AlarmMusic? lastCurrent = null;
-        AlarmMusic? lastTentative = null;
+        AlarmMusic lastCurrent = null;
+        AlarmMusic lastTentative = null;
         var subscription2 = ReduxContainer.Store.Subscribe(state =>
         {
             if (state.CurrentMusic != null && state.TentativeMusic != null

src/Bible.Alarm/ViewModels/ScheduleListItem.cs

@@ -19,7 +19,6 @@ public class ScheduleListItem : ObservableObject, IComparable, IDisposable, IRec
     private readonly IServiceScopeFactory _scopeFactory;
 
     public AlarmSchedule Schedule;
-    private readonly IDisposable _subscription;
 
     public ScheduleListItem(AlarmSchedule schedule, ILogger logger, IServiceScopeFactory scopeFactory)
     {

src/Bible.Alarm/ViewModels/ScheduleViewModel.cs

@@ -71,7 +71,7 @@ public ScheduleViewModel(
 
         //set schedules from initial state.
         //this should fire only once (look at the where condition).
-        ScheduleListItem? lastScheduleListItem = null;
+        ScheduleListItem lastScheduleListItem = null;
         bool modelInitialized = false;
         IDisposable subscription = null;
         subscription = ReduxContainer.Store.Subscribe(async state =>
@@ -123,7 +123,7 @@ public ScheduleViewModel(
 
         _subscriptions.Add(subscription);
 
-        AlarmMusic? lastMusic = null;
+        AlarmMusic lastMusic = null;
         var subscription2 = ReduxContainer.Store.Subscribe(state =>
         {
             if (state.CurrentMusic != null && state.CurrentMusic != lastMusic && state.CurrentMusic != Music)
@@ -136,7 +136,7 @@ public ScheduleViewModel(
 
         _subscriptions.Add(subscription2);
 
-        BibleReadingSchedule? lastBibleReading = null;
+        BibleReadingSchedule lastBibleReading = null;
         var subscription3 = ReduxContainer.Store.Subscribe(state =>
         {
             if (state.CurrentBibleReadingSchedule != null && state.CurrentBibleReadingSchedule != lastBibleReading && state.CurrentBibleReadingSchedule != BibleReadingSchedule)