Remove index update jobs

Author: justcoding121

.tools/Bible.Alarm.AudioLinksHarvestor/Bible.Alarm.AudioLinksHarvestor.csproj

@@ -8,7 +8,6 @@
   </PropertyGroup>
 
   <ItemGroup>
-    <PackageReference Include="AWSSDK.S3" Version="4.0.16.2" />
     <PackageReference Include="Microsoft.Extensions.DependencyInjection.Abstractions" Version="10.0.1" />
     <PackageReference Include="Polly" Version="8.6.5" />
     <PackageReference Include="Serilog" Version="4.3.0" />

.tools/Bible.Alarm.AudioLinksHarvestor/Program.cs

@@ -8,9 +8,6 @@
 using System.Linq;
 using System.Text.Json;
 using System.Threading.Tasks;
-using Amazon;
-using Amazon.S3;
-using Amazon.S3.Model;
 using Bible.Alarm.AudioLinksHarvestor.Harvestors.Bible;
 using Bible.Alarm.AudioLinksHarvestor.Harvestors.Drama;
 using Bible.Alarm.AudioLinksHarvestor.Harvestors.Music;
@@ -227,14 +224,8 @@ public static async Task<int> Main(string[] args)
                 throw new ApplicationException($"New index file size ({newIndexFileSize / 1024}kb) is significantly smaller than old index file size ({originalIndexFileSize / 1024}kb). This could indicate data loss.");
             }
 
-            if (!isTestRun)
-            {
-                await PublishToCloudFront(logger);
-            }
-            else
-            {
-                logger.Information("=== TEST RUN: Skipping cloud publishing ===");
-            }
+            // Media index is now packaged with the app only, updated on app updates
+            // No longer publishing to AWS S3/CloudFront
         }
         catch (Exception ex)
         {
@@ -320,53 +311,4 @@ private static void DeleteDirectory(string path)
         }
     }
 
-    private static async Task PublishToCloudFront(ILogger logger)
-    {
-        var keyPrefix = "bible-alarm/media-index";
-        var bucketName = "jthomas.info";
-        using var s3Client = new AmazonS3Client(RegionEndpoint.GetBySystemName("ca-central-1"));
-
-        var listObjectsResponse = await s3Client.ListObjectsAsync(new ListObjectsRequest
-        {
-            Prefix = $"{keyPrefix}/",
-            BucketName = bucketName
-        });
-
-        var utcTime = DateTime.UtcNow;
-        // Use new file name format with prefix (e.g., "v2-7-1-2024.zip")
-        var fileName = $"{AppConstants.ApiEndpoints.MediaIndexFileNamePrefix}{utcTime.Day}-{utcTime.Month}-{utcTime.Year}.zip";
-        var keyName = $"{keyPrefix}/{fileName}";
-        await s3Client.PutObjectAsync(new PutObjectRequest
-        {
-            BucketName = bucketName,
-            Key = keyName,
-            FilePath = $"{DirectoryHelper.IndexDirectory}/index.zip",
-
-        });
-
-        // Only delete files with the new prefix format to preserve pre-migration files
-        if (listObjectsResponse.S3Objects.Count > 0)
-        {
-            var deleteObjectsRequest = new DeleteObjectsRequest
-            {
-                BucketName = bucketName
-            };
-
-            listObjectsResponse.S3Objects.ForEach(x =>
-            {
-                // Only delete files with the new prefix format (v2-), preserve old format files
-                if (x.Key != keyName && x.Key.Contains($"{keyPrefix}/{AppConstants.ApiEndpoints.MediaIndexFileNamePrefix}"))
-                {
-                    deleteObjectsRequest.AddKey(x.Key);
-                }
-            });
-
-            if (deleteObjectsRequest.Objects.Count > 0)
-            {
-                await s3Client.DeleteObjectsAsync(deleteObjectsRequest);
-            }
-
-        }
-
-    }
 }

src/Bible.Alarm/Platforms/Android/Services/Bootstrap/AndroidPlatformBootstrapService.cs

@@ -121,7 +121,6 @@ private static void CreateNotificationChannel()
     private static void VerifyBackgroundTasks(Context context)
     {
         SchedulerSetupTask(context);
-        UpdateMediaIndexJobTask(context);
     }
 
     private static bool SchedulerSetupTask(Context context)
@@ -151,31 +150,4 @@ private static bool SchedulerSetupTask(Context context)
         return success;
     }
 
-    private static bool UpdateMediaIndexJobTask(Context context)
-    {
-        // Update media index every 24 hours (1440 minutes)
-        using var jobBuilder = context.CreateJobBuilderUsingJobId<UpdateMediaIndexJob>(UpdateMediaIndexJob.JobId, 1440);
-        var jobInfo = jobBuilder.Build();
-
-        var jobScheduler = (JobScheduler?)context.GetSystemService(Context.JobSchedulerService);
-        if (jobScheduler == null || jobInfo == null)
-        {
-            logger.Warning("Failed to schedule UpdateMediaIndexJob - JobScheduler or JobInfo is null");
-            return false;
-        }
-
-        var scheduleResult = jobScheduler.Schedule(jobInfo);
-        var success = JobScheduler.ResultSuccess == scheduleResult;
-
-        if (success)
-        {
-            logger.Debug("UpdateMediaIndexJob scheduled successfully");
-        }
-        else
-        {
-            logger.Warning("Failed to schedule UpdateMediaIndexJob - result: {Result}", scheduleResult);
-        }
-
-        return success;
-    }
 }

src/Bible.Alarm/Platforms/Android/Services/Helpers/AndroidBootstrapHelper.cs

@@ -43,7 +43,6 @@ public static async Task Initialize(ILogger logger, Context context, AndroidAppl
     private static void VerifyBackgroundTasks(Context context)
     {
         SchedulerSetupTask(context);
-        UpdateMediaIndexJobTask(context);
     }
 
     private static bool SchedulerSetupTask(Context context)
@@ -68,28 +67,6 @@ private static bool SchedulerSetupTask(Context context)
     }
 
 
-    private static bool UpdateMediaIndexJobTask(Context context)
-    {
-        // Update media index every 24 hours (1440 minutes)
-        using var jobBuilder = context.CreateJobBuilderUsingJobId<UpdateMediaIndexJob>(UpdateMediaIndexJob.JobId, 1440);
-        var jobInfo = jobBuilder.Build();
-
-        var jobScheduler = (JobScheduler)context.GetSystemService(Context.JobSchedulerService);
-        if (jobScheduler == null)
-        {
-            return false;
-        }
-
-        if (jobInfo == null)
-        {
-            return false;
-        }
-
-        var scheduleResult = jobScheduler.Schedule(jobInfo);
-
-        return JobScheduler.ResultSuccess == scheduleResult;
-
-    }
 
     private static void CreateNotificationChannel()
     {

src/Bible.Alarm/Platforms/Android/Services/Jobs/UpdateMediaIndexJob.cs

@@ -39,7 +39,6 @@ private static Task SetupBackgroundTask()
         IsBackgroundTaskEnabled = true;
 
         // Note: Media index update background task handler is available at:
-        // Platforms.Windows.Services.BackgroundTasks.UpdateMediaIndexBackgroundTask
         // This can be called from Windows Task Scheduler or app lifecycle events
         // WinUI 3 doesn't support UWP background tasks the same way as UWP
 

src/Bible.Alarm/Platforms/Windows/Helpers/WindowsBootstrapHelper.cs

@@ -1,6 +1,5 @@
 #nullable enable
 
-using Bible.Alarm.Platforms.Windows.Services.BackgroundTasks;
 using Bible.Alarm.Services.Scheduler.Interfaces;
 using Serilog;
 
@@ -9,7 +8,6 @@ namespace Bible.Alarm.Platforms.Windows.Helpers;
 /// <summary>
 /// Manages periodic background tasks for Windows (similar to Android JobScheduler).
 /// - SchedulerService: Runs every 30 minutes (like Android SchedulerJob)
-/// - UpdateMediaIndexBackgroundTask: Runs every 24 hours (like Android UpdateMediaIndexJob)
 /// </summary>
 public sealed class WindowsPeriodicBackgroundTasks : IDisposable
 {
@@ -18,7 +16,6 @@ public sealed class WindowsPeriodicBackgroundTasks : IDisposable
 
     // Periodic timers for Windows background tasks
     private PeriodicTimer? schedulerTimer; // Runs every 30 minutes (like Android SchedulerJob)
-    private PeriodicTimer? mediaIndexTimer; // Runs every 24 hours (like Android UpdateMediaIndexJob)
     private CancellationTokenSource? timersCancellationTokenSource;
     private readonly object timersLock = new();
     private bool isDisposed;
@@ -52,13 +49,7 @@ public void Start()
             schedulerTimer = new PeriodicTimer(TimeSpan.FromMinutes(30));
             _ = RunSchedulerTaskAsync(schedulerTimer, cancellationToken);
 
-            // Run media index update task immediately on start
-            _ = RunMediaIndexUpdateTaskOnceAsync(cancellationToken);
-            // Then start periodic timer (every 24 hours, like Android UpdateMediaIndexJob)
-            mediaIndexTimer = new PeriodicTimer(TimeSpan.FromHours(24));
-            _ = RunMediaIndexUpdateTaskAsync(mediaIndexTimer, cancellationToken);
-
-            logger.Information("Started periodic background tasks for Windows: Scheduler (30 min), MediaIndex (24 hours) - running immediately on start");
+            logger.Information("Started periodic background tasks for Windows: Scheduler (30 min) - running immediately on start");
         }
     }
 
@@ -111,52 +102,6 @@ private async Task RunSchedulerTaskAsync(PeriodicTimer timer, CancellationToken
         }
     }
 
-    /// <summary>
-    /// Runs the media index update task once immediately on app start.
-    /// </summary>
-    private async Task RunMediaIndexUpdateTaskOnceAsync(CancellationToken cancellationToken)
-    {
-        try
-        {
-            logger.Debug("Running media index update task immediately on app start");
-            await UpdateMediaIndexBackgroundTask.HandleAsync();
-        }
-        catch (Exception e)
-        {
-            logger.Error(e, "Error running media index update task on app start");
-        }
-    }
-
-    /// <summary>
-    /// Runs the media index update task periodically (every 24 hours, like Android UpdateMediaIndexJob)
-    /// </summary>
-    private async Task RunMediaIndexUpdateTaskAsync(PeriodicTimer timer, CancellationToken cancellationToken)
-    {
-        try
-        {
-            while (await timer.WaitForNextTickAsync(cancellationToken))
-            {
-                try
-                {
-                    logger.Debug("Windows periodic media index update task running (every 24 hours)");
-                    await UpdateMediaIndexBackgroundTask.HandleAsync();
-                }
-                catch (Exception e)
-                {
-                    logger.Error(e, "Error in Windows periodic media index update task");
-                }
-            }
-        }
-        catch (OperationCanceledException)
-        {
-            // Expected when timer is stopped
-            logger.Debug("Windows media index update timer stopped");
-        }
-        catch (Exception e)
-        {
-            logger.Error(e, "Unexpected error in Windows media index update timer");
-        }
-    }
 
     public void Dispose()
     {
@@ -177,9 +122,6 @@ public void Dispose()
             schedulerTimer?.Dispose();
             schedulerTimer = null;
 
-            mediaIndexTimer?.Dispose();
-            mediaIndexTimer = null;
-
             logger.Debug("Stopped and disposed Windows periodic background task timers");
         }
     }