Use factory pattern for schedule list items

Author: justcoding121

src/Bible.Alarm/MauiProgram.cs

@@ -31,6 +31,7 @@
 using Bible.Alarm.Views.Shared;
 using Bible.Alarm.ViewModels.Bible;
 using Bible.Alarm.ViewModels.Music;
+using Bible.Alarm.Models.Schedule;
 using Microsoft.EntityFrameworkCore;
 #if IOS
 using Bible.Alarm.Platforms.iOS.Services.Storage;
@@ -224,6 +225,18 @@ private static void RegisterViewModels(IServiceCollection services)
         services.AddTransient<ChapterSelectionViewModel>();
         services.AddTransient<AlarmViewModal>();
         services.AddSingleton<MediaProgressViewModal>();
+        
+        // Register ScheduleListItem as transient for list items
+        services.AddTransient<ScheduleListItem>();
+        
+        // Register factory for ScheduleListItem (takes AlarmSchedule and returns ScheduleListItem with DI)
+        services.AddTransient<Func<AlarmSchedule, ScheduleListItem>>(serviceProvider => 
+            schedule =>
+            {
+                var vm = serviceProvider.GetRequiredService<ScheduleListItem>();
+                vm.Initialize(schedule);
+                return vm;
+            });
     }
 
     private static void RegisterUiComponents(IServiceCollection services)

src/Bible.Alarm/ViewModels/HomeViewModel.cs

@@ -39,6 +39,7 @@ public class HomeViewModel : ObservableObject, IDisposable, IRecipient<Initializ
     // Map AlarmSchedule IDs to ScheduleListItem ViewModels for UI binding
     private readonly Dictionary<long, ScheduleListItem> _scheduleViewModels = [];
 
+    private readonly Func<AlarmSchedule, ScheduleListItem> _scheduleListItemFactory;
 
     private readonly Fluxor.IDispatcher _dispatcher;
     private readonly IState<ApplicationState> _state;
@@ -53,6 +54,7 @@ public HomeViewModel(
         IAlarmService alarmService,
         INotificationService notificationService,
         IServiceScopeFactory scopeFactory,
+        Func<AlarmSchedule, ScheduleListItem> scheduleListItemFactory,
         Fluxor.IDispatcher dispatcher,
         IState<ApplicationState> state)
     {
@@ -62,6 +64,7 @@ public HomeViewModel(
         _alarmService = alarmService;
         _notificationService = notificationService;
         _scopeFactory = scopeFactory;
+        _scheduleListItemFactory = scheduleListItemFactory;
         _dispatcher = dispatcher;
         _state = state;
 
@@ -218,9 +221,6 @@ public ObservableHashSet<ScheduleListItem> Schedules
 
     private void UpdateScheduleViewModels(ObservableHashSet<AlarmSchedule> schedules)
     {
-        using var scope = _scopeFactory.CreateScope();
-        var logger = scope.ServiceProvider.GetRequiredService<ILogger>();
-        
         var newViewModels = new ObservableHashSet<ScheduleListItem>();
         var currentViewModelIds = new HashSet<long>();
 
@@ -232,14 +232,14 @@ private void UpdateScheduleViewModels(ObservableHashSet<AlarmSchedule> schedules
             if (_scheduleViewModels.TryGetValue(schedule.Id, out var existingViewModel))
             {
                 // Update existing ViewModel's Schedule property
-                existingViewModel.Schedule = schedule;
+                existingViewModel.Initialize(schedule);
                 existingViewModel.IsEnabled = schedule.IsEnabled;
                 newViewModels.Add(existingViewModel);
             }
             else
             {
-                // Create new ViewModel
-                var viewModel = new ScheduleListItem(schedule, logger, _scopeFactory);
+                // Create new ViewModel using factory with full DI
+                var viewModel = _scheduleListItemFactory(schedule);
                 _scheduleViewModels[schedule.Id] = viewModel;
                 newViewModels.Add(viewModel);
             }

src/Bible.Alarm/ViewModels/ScheduleListItem.cs

@@ -19,12 +19,20 @@ public class ScheduleListItem : ObservableObject, IComparable, IDisposable, IRec
     private readonly ILogger _logger;
     private readonly IServiceScopeFactory _scopeFactory;
 
-    public AlarmSchedule Schedule;
+    public AlarmSchedule Schedule { get; private set; }
 
-    public ScheduleListItem(AlarmSchedule schedule, ILogger logger, IServiceScopeFactory scopeFactory)
+    // Constructor for DI - Initialize() must be called after construction
+    public ScheduleListItem(ILogger logger, IServiceScopeFactory scopeFactory)
     {
         _logger = logger;
         _scopeFactory = scopeFactory;
+        
+        // Commands will be initialized in Initialize() method
+    }
+
+    // Initialize method to set the schedule data
+    public void Initialize(AlarmSchedule schedule)
+    {
         Schedule = schedule;
         _isEnabled = schedule.IsEnabled;
 
@@ -66,7 +74,7 @@ await toastService.ShowMessage("Error. Network may not be available." +
             if (!await CanMove()) return;
             using var scope = _scopeFactory.CreateScope();
             using var playlistService = scope.ServiceProvider.GetRequiredService<IPlaylistService>();
-            await playlistService.MoveToPreviousBibleChapter(schedule.Id);
+            await playlistService.MoveToPreviousBibleChapter(Schedule.Id);
 
             RefreshChapterName(true);
         });
@@ -77,7 +85,7 @@ await toastService.ShowMessage("Error. Network may not be available." +
 
             using var scope = _scopeFactory.CreateScope();
             using var playlistService = scope.ServiceProvider.GetRequiredService<IPlaylistService>();
-            await playlistService.MoveToNextBibleChapter(schedule.Id);
+            await playlistService.MoveToNextBibleChapter(Schedule.Id);
 
             RefreshChapterName(true);
         });