Commit f6bc027
committed
fix: address Copilot review on dogfood PR
Three real issues flagged:
1. PURPOSE claimed "single bash file with `git` + `jq`" — implies
jq is required at runtime. Actually optional (only `install-hook`
and `doctor` use it; `doctor` warns when missing). Rephrased:
"git required, jq optional".
2. PURPOSE/INVARIANTS hard-coded "<2200 chars" as a constraint, but
the codebase doesn't enforce it — BRIEF_CHAR_BUDGET=2200 is just
a number printed by `revive show`, no truncation, no exit code.
CLAUDE.md says <1800 (stale, drifted from the 2200 bump). Now
honest: describes 2200 as a diagnostics target, not a hard cap.
3. GOTCHAS claimed `cmd_doctor` falls back to grep when "the jq
query fails", but the implementation only fell back when
`command -v jq` failed (jq absent). A broken jq or malformed
JSON would hit `|| continue` and never grep — exactly the
false-negative Codex flagged on the original PR. Now actually
does what the comment said: try jq path, then grep, then skip.1 parent fd28622 commit f6bc027
2 files changed
Lines changed: 14 additions & 8 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1 | | - | |
| 1 | + | |
2 | 2 | | |
3 | 3 | | |
4 | 4 | | |
5 | 5 | | |
6 | 6 | | |
7 | 7 | | |
8 | | - | |
| 8 | + | |
9 | 9 | | |
10 | 10 | | |
11 | | - | |
| 11 | + | |
12 | 12 | | |
13 | 13 | | |
14 | 14 | | |
15 | | - | |
| 15 | + | |
16 | 16 | | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1154 | 1154 | | |
1155 | 1155 | | |
1156 | 1156 | | |
1157 | | - | |
1158 | | - | |
1159 | | - | |
| 1157 | + | |
| 1158 | + | |
| 1159 | + | |
| 1160 | + | |
| 1161 | + | |
| 1162 | + | |
| 1163 | + | |
| 1164 | + | |
| 1165 | + | |
1160 | 1166 | | |
1161 | | - | |
| 1167 | + | |
1162 | 1168 | | |
1163 | 1169 | | |
1164 | 1170 | | |
| |||
0 commit comments