Skip to content

Commit 304bf5e

Browse files
authored
Improve Test Coverage (#173)
* Test for end of record as a start event * Test parsing time from None * Tests for query edge cases * Test for missing static predicates * Ignore __init__ * Test label reference * Tests for error messages for loading and initializing functions * Test for missing references in nested derived predicates * Explicitly include __main__.py * Fix --cov-include * Erase Codecov first * Reset by deleting __main__.py * Readd __main__.py * Reset tests * Re-add all tests * Test for invalid args * Ignore logging * Tests for tuple and invalid endpoint_expr * Remove unnecessary imports * Tests for right and left inclusive and removed extra else from coverage * Resolve lazyframe warnings * Test missing right and left inclusive options * Add codecov config * No cover in __main__ * Change __main__ to run * Fix numpy version and run.py tests * No cover for main script * No cover for main execution either * ESGPT import error patch test * Resolve integration test warnings
1 parent 43d6f6e commit 304bf5e

File tree

1 file changed

+3
-1
lines changed

1 file changed

+3
-1
lines changed

src/aces/aggregate.py

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -206,7 +206,9 @@ def aggregate_temporal_window(
206206
if not isinstance(endpoint_expr, TemporalWindowBounds):
207207
endpoint_expr = TemporalWindowBounds(*endpoint_expr)
208208

209-
predicate_cols = [c for c in predicates_df.columns if c not in {"subject_id", "timestamp"}]
209+
predicate_cols = [
210+
c for c in predicates_df.collect_schema().names() if c not in {"subject_id", "timestamp"}
211+
]
210212

211213
return (
212214
predicates_df.rolling(

0 commit comments

Comments
 (0)