Rewrote mage/adminhtml/sales.js without prototypejs

Author: justinbeaty

app/code/core/Mage/Adminhtml/Block/Sales/Order/Create/Items.php

@@ -6,7 +6,7 @@
  * @package    Mage_Adminhtml
  * @copyright  Copyright (c) 2006-2020 Magento, Inc. (https://magento.com)
  * @copyright  Copyright (c) 2022-2024 The OpenMage Contributors (https://openmage.org)
- * @copyright  Copyright (c) 2024 Maho (https://mahocommerce.com)
+ * @copyright  Copyright (c) 2024-2025 Maho (https://mahocommerce.com)
  * @license    https://opensource.org/licenses/osl-3.0.php  Open Software License (OSL 3.0)
  */
 
@@ -19,17 +19,18 @@ class Mage_Adminhtml_Block_Sales_Order_Create_Items extends Mage_Adminhtml_Block
 {
     /**
      * Contains button descriptions to be shown at the top of accordion
-     * @var array
+     * @var list<array>
      */
     protected $_buttons = [];
 
-    /**
-     * Define block ID
-     */
     public function __construct()
     {
         parent::__construct();
         $this->setId('sales_order_create_items');
+        $this->addButton([
+            'label' => Mage::helper('sales')->__('Add Products'),
+            'onclick' => 'order.productGridShow()',
+        ]);
     }
 
     /**

app/code/core/Mage/Adminhtml/Block/Sales/Order/Create/Search.php

@@ -6,6 +6,7 @@
  * @package    Mage_Adminhtml
  * @copyright  Copyright (c) 2006-2020 Magento, Inc. (https://magento.com)
  * @copyright  Copyright (c) 2022-2024 The OpenMage Contributors (https://openmage.org)
+ * @copyright  Copyright (c) 2025 Maho (https://mahocommerce.com)
  * @license    https://opensource.org/licenses/osl-3.0.php  Open Software License (OSL 3.0)
  */
 
@@ -16,10 +17,25 @@
  */
 class Mage_Adminhtml_Block_Sales_Order_Create_Search extends Mage_Adminhtml_Block_Sales_Order_Create_Abstract
 {
+    /**
+     * Contains button descriptions to be shown at the top of accordion
+     * @var list<array>
+     */
+    protected $_buttons = [];
+
     public function __construct()
     {
         parent::__construct();
         $this->setId('sales_order_create_search');
+        $this->addButton([
+            'label' => Mage::helper('sales')->__('Add Selected Product(s) to Order'),
+            'onclick' => 'order.productGridAddSelected()',
+            'class' => 'add',
+        ]);
+        $this->addButton([
+            'label' => Mage::helper('sales')->__('Cancel'),
+            'onclick' => 'order.productGridHide()',
+        ]);
     }
 
     /**
@@ -31,16 +47,30 @@ public function getHeaderText()
     }
 
     /**
+     * Add button to the items header
+     *
+     * @param array $args
+     */
+    public function addButton($args)
+    {
+        $this->_buttons[] = $args;
+    }
+
+    /**
+     * Render buttons and return HTML code
+     *
      * @return string
      */
     public function getButtonsHtml()
     {
-        $addButtonData = [
-            'label' => Mage::helper('sales')->__('Add Selected Product(s) to Order'),
-            'onclick' => 'order.productGridAddSelected()',
-            'class' => 'add',
-        ];
-        return $this->getLayout()->createBlock('adminhtml/widget_button')->setData($addButtonData)->toHtml();
+        $html = '';
+        // Make buttons to be rendered in opposite order of addition. This makes "Add products" the last one.
+        $this->_buttons = array_reverse($this->_buttons);
+        foreach ($this->_buttons as $buttonData) {
+            $html .= $this->getLayout()->createBlock('adminhtml/widget_button')->setData($buttonData)->toHtml();
+        }
+
+        return $html;
     }
 
     /**

app/design/adminhtml/default/default/template/sales/order/create/abstract.phtml

@@ -13,8 +13,8 @@
 ?>
 <div class="entry-edit">
     <div class="entry-edit-head">
-        <div style="float: right;"><?= $this->getButtonsHtml() ?></div>
-        <h4 class="fieldset-legend <?= ($this->getHeaderCssClass()) ? $this->getHeaderCssClass().' icon-head' : '' ?>"><?= $this->getHeaderText() ?></h4>
+        <h4 class="fieldset-legend <?= $this->getHeaderCssClass() ?: '' ?>"><?= $this->getHeaderText() ?></h4>
+        <div class="form-buttons"><?= $this->getButtonsHtml() ?></div>
     </div>
     <div class="fieldset">
         <?= $this->getChildHtml('', true, true) ?>

public/js/mage/adminhtml/product/composite/configure.js

@@ -491,9 +491,16 @@ class ProductConfigure // Maho.Admin.Controller.ProductConfigurePopup
     /**
      * Helper to find qty of currently confirmed item
      */
-    getCurrentConfirmedQtyElement() {
+    getCurrentConfirmedBlock() {
         const { listType, itemId } = this.current;
-        return this._getConfirmedBlock(listType, itemId).querySelector('input[name=qty]');
+        return this._getConfirmedBlock(listType, itemId);
+    }
+
+    /**
+     * Helper to find qty of currently confirmed item
+     */
+    getCurrentConfirmedQtyElement() {
+        return this.getCurrentConfirmedBlock().querySelector('input[name=qty]');
     }
 
     /**