Skip to content

Commit a2fa8d6

Browse files
committed
feat: rename methods for clarity in ZSpace media server integration
1 parent ed9116d commit a2fa8d6

2 files changed

Lines changed: 19 additions & 19 deletions

File tree

app/modules/zspace/zspace.py

Lines changed: 17 additions & 17 deletions
Original file line numberDiff line numberDiff line change
@@ -77,11 +77,11 @@ def reconnect(self) -> bool:
7777
self.folders = []
7878
self.serverid = None
7979
return False
80-
self.folders = self.get_emby_folders()
80+
self.folders = self.get_library_folders()
8181
self.serverid = self.get_server_id()
8282
return True
8383

84-
def get_emby_folders(self) -> List[dict]:
84+
def get_library_folders(self) -> List[dict]:
8585
"""
8686
获取极影视媒体库路径列表
8787
"""
@@ -102,7 +102,7 @@ def get_emby_folders(self) -> List[dict]:
102102
logger.error(f"连接Library/SelectableMediaFolders 出错:{e}")
103103
return []
104104

105-
def get_emby_virtual_folders(self) -> List[dict]:
105+
def get_virtual_folders(self) -> List[dict]:
106106
"""
107107
获取极影视媒体库所有路径列表(包含共享路径)
108108
"""
@@ -116,7 +116,7 @@ def get_emby_virtual_folders(self) -> List[dict]:
116116
res = RequestUtils().get_res(url, params)
117117
if res:
118118
library_items = res.json().get("Items")
119-
librarys = []
119+
libraries = []
120120
for library_item in library_items or []:
121121
library_id = library_item.get('ItemId')
122122
library_name = library_item.get('Name')
@@ -129,20 +129,20 @@ def get_emby_virtual_folders(self) -> List[dict]:
129129
library_paths.append(path.get('Path'))
130130

131131
if library_name and library_paths:
132-
librarys.append({
132+
libraries.append({
133133
'Id': library_id,
134134
'Name': library_name,
135135
'Path': library_paths
136136
})
137-
return librarys
137+
return libraries
138138
else:
139139
logger.error("Library/VirtualFolders/Query 未获取到返回数据")
140140
return []
141141
except Exception as e:
142142
logger.error(f"连接Library/VirtualFolders/Query 出错:{e}")
143143
return []
144144

145-
def __get_emby_librarys(self, username: Optional[str] = None) -> List[dict]:
145+
def __get_library_views(self, username: Optional[str] = None) -> List[dict]:
146146
"""
147147
获取极影视媒体库列表
148148
"""
@@ -175,7 +175,7 @@ def get_librarys(self, username: Optional[str] = None, hidden: Optional[bool] =
175175
if not self._host or not self._apikey:
176176
return []
177177
libraries = []
178-
for library in self.__get_emby_librarys(username) or []:
178+
for library in self.__get_library_views(username) or []:
179179
if hidden and self._sync_libraries and "all" not in self._sync_libraries \
180180
and library.get("Id") not in self._sync_libraries:
181181
continue
@@ -315,7 +315,7 @@ def get_medias_count(self) -> schemas.Statistic:
315315
logger.error(f"连接Items/Counts出错:{e}")
316316
return schemas.Statistic()
317317

318-
def __get_emby_series_id_by_name(self, name: str, year: str) -> Optional[str]:
318+
def __get_series_id_by_name(self, name: str, year: str) -> Optional[str]:
319319
"""
320320
根据名称查询极影视中剧集的 SeriesId
321321
:param name: 标题
@@ -414,15 +414,15 @@ def get_tv_episodes(self,
414414
return None, None
415415
cached_item_id = item_id
416416
if not item_id:
417-
item_id = self.__get_emby_series_id_by_name(title, year)
417+
item_id = self.__get_series_id_by_name(title, year)
418418
if item_id is None:
419419
return None, None
420420
if not item_id:
421421
return None, {}
422422
item_info = self.get_iteminfo(item_id)
423423
if not item_info and cached_item_id and title:
424424
logger.warning(f"极影视缓存的电视剧媒体ID {cached_item_id} 已失效,尝试按标题重新搜索:{title}")
425-
item_id = self.__get_emby_series_id_by_name(title, year)
425+
item_id = self.__get_series_id_by_name(title, year)
426426
if item_id is None:
427427
return None, None
428428
if not item_id:
@@ -516,7 +516,7 @@ def generate_external_image_link(self, item_id: str, image_type: str) -> Optiona
516516
logger.error(f"连接Items/Id/Images出错:{e}")
517517
return None
518518

519-
def __refresh_emby_library_by_id(self, item_id: str) -> bool:
519+
def __refresh_library_by_id(self, item_id: str) -> bool:
520520
"""
521521
通知极影视刷新一个项目的媒体库
522522
"""
@@ -569,26 +569,26 @@ def refresh_library_by_items(self, items: List[schemas.RefreshMediaItem]) -> Opt
569569
logger.info("开始刷新极影视媒体库...")
570570
library_ids = []
571571
for item in items:
572-
library_id = self.__get_emby_library_id_by_item(item)
572+
library_id = self.__get_library_id_by_item(item)
573573
if library_id and library_id not in library_ids:
574574
library_ids.append(library_id)
575575
if "/" in library_ids:
576576
return self.refresh_root_library()
577577
for library_id in library_ids:
578578
if library_id != "/":
579-
return self.__refresh_emby_library_by_id(library_id)
579+
return self.__refresh_library_by_id(library_id)
580580
logger.info("极影视媒体库刷新完成")
581581
return True
582582

583-
def __get_emby_library_id_by_item(self, item: schemas.RefreshMediaItem) -> Optional[str]:
583+
def __get_library_id_by_item(self, item: schemas.RefreshMediaItem) -> Optional[str]:
584584
"""
585585
根据媒体信息查询在哪个媒体库,返回要刷新的位置的ID
586586
:param item: {title, year, type, category, target_path}
587587
"""
588588
if not item.title or not item.year or not item.type:
589589
return None
590590
if item.type != MediaType.MOVIE.value:
591-
item_id = self.__get_emby_series_id_by_name(item.title, item.year)
591+
item_id = self.__get_series_id_by_name(item.title, item.year)
592592
if item_id:
593593
return item_id
594594
else:
@@ -1009,7 +1009,7 @@ def get_user_library_folders(self):
10091009
if not self._host or not self._apikey:
10101010
return []
10111011
library_folders = []
1012-
for library in self.get_emby_virtual_folders() or []:
1012+
for library in self.get_virtual_folders() or []:
10131013
if self._sync_libraries and library.get("Id") not in self._sync_libraries:
10141014
continue
10151015
library_folders += [folder for folder in library.get("Path")]

tests/test_mediaserver_tv_stale_itemid.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -160,7 +160,7 @@ def test_zspace_tv_episodes_fallback_when_cached_item_id_missing(self):
160160
client._apikey = "api-key"
161161
client.user = "user-id"
162162
client.get_iteminfo = Mock(side_effect=[None, SimpleNamespace(tmdbid=12345)])
163-
client._ZSpace__get_emby_series_id_by_name = Mock(return_value="new-series-id")
163+
client._ZSpace__get_series_id_by_name = Mock(return_value="new-series-id")
164164

165165
with patch("app.modules.zspace.zspace.RequestUtils") as request_utils_cls:
166166
request_utils_cls.return_value.get_res.return_value = _FakeResponse({
@@ -176,7 +176,7 @@ def test_zspace_tv_episodes_fallback_when_cached_item_id_missing(self):
176176

177177
self.assertEqual(item_id, "new-series-id")
178178
self.assertEqual(episodes, {1: [1]})
179-
client._ZSpace__get_emby_series_id_by_name.assert_called_once_with("测试剧集", "2026")
179+
client._ZSpace__get_series_id_by_name.assert_called_once_with("测试剧集", "2026")
180180

181181
def test_ugreen_tv_episodes_fallback_when_cached_item_id_missing(self):
182182
"""绿联缓存ID失效时,应重新搜索剧集ID后再查询集信息。"""

0 commit comments

Comments
 (0)