Add resyncPeriod option for drift detection

This change introduces a new `resyncPeriod` field in `ManagedOptions` that
enables periodic reconciliation of resources to detect and correct drift
from the desired state in OpenStack.

Motivation:
Resources managed by ORC can drift from their desired state due to
external modifications in OpenStack. Without drift detection, these
changes go unnoticed until the next spec change triggers reconciliation.
The resyncPeriod option allows users to configure periodic checks to
detect and remediate such drift automatically.

Implementation:
- Add `resyncPeriod` field (metav1.Duration) to ManagedOptions API
- Add GetResyncPeriod() helper method for safe access with nil handling
- Modify shouldReconcile() in the generic controller to check if enough
  time has passed since the last successful reconciliation
- Schedule next resync when periodic resync is enabled and no other
  reschedule is pending
- Update all CRDs, OpenAPI schema, and documentation

Usage:
```yaml
spec:
  managedOptions:
    resyncPeriod: 1h  # Reconcile every hour to detect drift
```

If not specified or set to 0, periodic resync is disabled (default
behavior unchanged).

Closes: #655

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>

Author: eshulman2

api/v1alpha1/controller_options.go

@@ -16,6 +16,10 @@ limitations under the License.
 
 package v1alpha1
 
+import (
+	metav1 "k8s.io/apimachinery/pkg/apis/meta/v1"
+)
+
 // +kubebuilder:validation:Enum:=managed;unmanaged
 type ManagementPolicy string
 
@@ -53,6 +57,14 @@ type ManagedOptions struct {
 	// +kubebuilder:default:=delete
 	// +optional
 	OnDelete OnDelete `json:"onDelete,omitempty"`
+
+	// resyncPeriod specifies the interval after which a successfully
+	// reconciled resource will be reconciled again to detect drift from the
+	// desired state. If not specified or set to 0, periodic resync is disabled
+	// and the resource will only be reconciled when the spec changes or when
+	// related resources change.
+	// +optional
+	ResyncPeriod *metav1.Duration `json:"resyncPeriod,omitempty"`
 }
 
 // GetOnDelete returns the delete behaviour from ManagedOptions. If called on a
@@ -63,3 +75,12 @@ func (o *ManagedOptions) GetOnDelete() OnDelete {
 	}
 	return o.OnDelete
 }
+
+// GetResyncPeriod returns the resync period from ManagedOptions. If called on a
+// nil receiver or if ResyncPeriod is not set, it returns 0 (disabled).
+func (o *ManagedOptions) GetResyncPeriod() metav1.Duration {
+	if o == nil || o.ResyncPeriod == nil {
+		return metav1.Duration{}
+	}
+	return *o.ResyncPeriod
+}

api/v1alpha1/zz_generated.deepcopy.go

@@ -125,6 +125,14 @@ spec:
                     - delete
                     - detach
                     type: string
+                  resyncPeriod:
+                    description: |-
+                      resyncPeriod specifies the interval after which a successfully
+                      reconciled resource will be reconciled again to detect drift from the
+                      desired state. If not specified or set to 0, periodic resync is disabled
+                      and the resource will only be reconciled when the spec changes or when
+                      related resources change.
+                    type: string
                 type: object
               managementPolicy:
                 default: managed

cmd/models-schema/zz_generated.openapi.go

@@ -137,6 +137,14 @@ spec:
                     - delete
                     - detach
                     type: string
+                  resyncPeriod:
+                    description: |-
+                      resyncPeriod specifies the interval after which a successfully
+                      reconciled resource will be reconciled again to detect drift from the
+                      desired state. If not specified or set to 0, periodic resync is disabled
+                      and the resource will only be reconciled when the spec changes or when
+                      related resources change.
+                    type: string
                 type: object
               managementPolicy:
                 default: managed

config/crd/bases/openstack.k-orc.cloud_domains.yaml

@@ -209,6 +209,14 @@ spec:
                     - delete
                     - detach
                     type: string
+                  resyncPeriod:
+                    description: |-
+                      resyncPeriod specifies the interval after which a successfully
+                      reconciled resource will be reconciled again to detect drift from the
+                      desired state. If not specified or set to 0, periodic resync is disabled
+                      and the resource will only be reconciled when the spec changes or when
+                      related resources change.
+                    type: string
                 type: object
               managementPolicy:
                 default: managed

config/crd/bases/openstack.k-orc.cloud_flavors.yaml

@@ -126,6 +126,14 @@ spec:
                     - delete
                     - detach
                     type: string
+                  resyncPeriod:
+                    description: |-
+                      resyncPeriod specifies the interval after which a successfully
+                      reconciled resource will be reconciled again to detect drift from the
+                      desired state. If not specified or set to 0, periodic resync is disabled
+                      and the resource will only be reconciled when the spec changes or when
+                      related resources change.
+                    type: string
                 type: object
               managementPolicy:
                 default: managed

config/crd/bases/openstack.k-orc.cloud_floatingips.yaml

@@ -139,6 +139,14 @@ spec:
                     - delete
                     - detach
                     type: string
+                  resyncPeriod:
+                    description: |-
+                      resyncPeriod specifies the interval after which a successfully
+                      reconciled resource will be reconciled again to detect drift from the
+                      desired state. If not specified or set to 0, periodic resync is disabled
+                      and the resource will only be reconciled when the spec changes or when
+                      related resources change.
+                    type: string
                 type: object
               managementPolicy:
                 default: managed

config/crd/bases/openstack.k-orc.cloud_groups.yaml

@@ -121,6 +121,14 @@ spec:
                     - delete
                     - detach
                     type: string
+                  resyncPeriod:
+                    description: |-
+                      resyncPeriod specifies the interval after which a successfully
+                      reconciled resource will be reconciled again to detect drift from the
+                      desired state. If not specified or set to 0, periodic resync is disabled
+                      and the resource will only be reconciled when the spec changes or when
+                      related resources change.
+                    type: string
                 type: object
               managementPolicy:
                 default: managed

config/crd/bases/openstack.k-orc.cloud_images.yaml

@@ -195,6 +195,14 @@ spec:
                     - delete
                     - detach
                     type: string
+                  resyncPeriod:
+                    description: |-
+                      resyncPeriod specifies the interval after which a successfully
+                      reconciled resource will be reconciled again to detect drift from the
+                      desired state. If not specified or set to 0, periodic resync is disabled
+                      and the resource will only be reconciled when the spec changes or when
+                      related resources change.
+                    type: string
                 type: object
               managementPolicy:
                 default: managed