Skip to content

Commit 2da7215

Browse files
committed
Address review comment for Limit controller
Add `resource.ServiceRef` check in the filter for serviceDependency creation
1 parent 60bb5b3 commit 2da7215

1 file changed

Lines changed: 1 addition & 1 deletion

File tree

internal/controllers/limit/controller.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -61,7 +61,7 @@ var serviceDependency = dependency.NewDeletionGuardDependency[*orcv1alpha1.Limit
6161
"spec.resource.serviceRef",
6262
func(limit *orcv1alpha1.Limit) []string {
6363
resource := limit.Spec.Resource
64-
if resource == nil {
64+
if resource == nil || resource.ServiceRef == "" {
6565
return nil
6666
}
6767
return []string{string(resource.ServiceRef)}

0 commit comments

Comments
 (0)