RegisteredLimit Tests and Config Samples

On-behalf-of: SAP nils.gondermann@sap.com

Author: gndrmnn

config/samples/openstack_v1alpha1_registeredlimit.yaml

@@ -1,14 +1,29 @@
 ---
 apiVersion: openstack.k-orc.cloud/v1alpha1
+kind: Service
+metadata:
+  name: registeredlimit-sample
+spec:
+  cloudCredentialsRef:
+    cloudName: openstack-admin
+    secretName: openstack-clouds
+  managementPolicy: unmanaged
+  import:
+    filter:
+      type: "compute"
+---
+apiVersion: openstack.k-orc.cloud/v1alpha1
 kind: RegisteredLimit
 metadata:
   name: registeredlimit-sample
 spec:
   cloudCredentialsRef:
-    # TODO(scaffolding): Use openstack-admin if the resource needs admin credentials to be created
-    cloudName: openstack
+    cloudName: openstack-admin
     secretName: openstack-clouds
   managementPolicy: managed
   resource:
     description: Sample RegisteredLimit
-    # TODO(scaffolding): Add all fields the resource supports
+    serviceRef: registeredlimit-sample
+    resourceName: vcpus
+    defaultLimit: 5
+    regionID: RegionOne

internal/controllers/registeredlimit/tests/registeredlimit-create-full/00-assert.yaml

@@ -5,9 +5,9 @@ metadata:
   name: registeredlimit-create-full
 status:
   resource:
-    name: registeredlimit-create-full-override
     description: RegisteredLimit from "create full" test
-    # TODO(scaffolding): Add all fields the resource supports
+    resourceName: vcpus
+    defaultLimit: 5
   conditions:
   - type: Available
     status: "True"
@@ -30,4 +30,4 @@ resourceRefs:
 assertAll:
     - celExpr: "registeredlimit.status.id != ''"
     - celExpr: "registeredlimit.status.resource.serviceID == service.status.id"
-    # TODO(scaffolding): Add more checks
+    - celExpr: "!has(registeredlimit.status.resource.name)"

internal/controllers/registeredlimit/tests/registeredlimit-create-full/00-create-resource.yaml

@@ -5,25 +5,24 @@ metadata:
   name: registeredlimit-create-full
 spec:
   cloudCredentialsRef:
-    # TODO(scaffolding): Use openstack-admin if the resource needs admin credentials to be created
-    cloudName: openstack
+    cloudName: openstack-admin
     secretName: openstack-clouds
   managementPolicy: managed
-  # TODO(scaffolding): Add the necessary fields to create the resource
-  resource: {}
+  resource:
+    type: registeredlimit-test
 ---
 apiVersion: openstack.k-orc.cloud/v1alpha1
 kind: RegisteredLimit
 metadata:
   name: registeredlimit-create-full
 spec:
   cloudCredentialsRef:
-    # TODO(scaffolding): Use openstack-admin if the resource needs admin credentials to be created
-    cloudName: openstack
+    cloudName: openstack-admin
     secretName: openstack-clouds
   managementPolicy: managed
   resource:
     name: registeredlimit-create-full-override
     description: RegisteredLimit from "create full" test
     serviceRef: registeredlimit-create-full
-    # TODO(scaffolding): Add all fields the resource supports
+    resourceName: vcpus
+    defaultLimit: 5

internal/controllers/registeredlimit/tests/registeredlimit-create-minimal/00-assert.yaml

@@ -5,8 +5,8 @@ metadata:
   name: registeredlimit-create-minimal
 status:
   resource:
-    name: registeredlimit-create-minimal
-    # TODO(scaffolding): Add all fields the resource supports
+    resourceName: vcpus
+    defaultLimit: 5
   conditions:
   - type: Available
     status: "True"
@@ -29,4 +29,4 @@ resourceRefs:
 assertAll:
     - celExpr: "registeredlimit.status.id != ''"
     - celExpr: "registeredlimit.status.resource.serviceID == service.status.id"
-    # TODO(scaffolding): Add more checks
+    - celExpr: "!has(registeredlimit.status.resource.name)"

internal/controllers/registeredlimit/tests/registeredlimit-create-minimal/00-create-resource.yaml

@@ -5,24 +5,23 @@ metadata:
   name: registeredlimit-create-minimal
 spec:
   cloudCredentialsRef:
-    # TODO(scaffolding): Use openstack-admin if the resource needs admin credentials to be created
-    cloudName: openstack
+    cloudName: openstack-admin
     secretName: openstack-clouds
-  managementPolicy: managed
-  # TODO(scaffolding): Add the necessary fields to create the resource
-  resource: {}
+  managementPolicy: unmanaged
+  import:
+    filter:
+      type: "compute"
 ---
 apiVersion: openstack.k-orc.cloud/v1alpha1
 kind: RegisteredLimit
 metadata:
   name: registeredlimit-create-minimal
 spec:
   cloudCredentialsRef:
-    # TODO(scaffolding): Use openstack-admin if the resource needs admin credentials to be created
-    cloudName: openstack
+    cloudName: openstack-admin
     secretName: openstack-clouds
   managementPolicy: managed
-  # TODO(scaffolding): Only add the mandatory fields. It's possible the resource
-  # doesn't have mandatory fields, in that case, leave it empty.
   resource:
     serviceRef: registeredlimit-create-minimal
+    resourceName: vcpus
+    defaultLimit: 5

internal/controllers/registeredlimit/tests/registeredlimit-dependency/00-create-resources-missing-deps.yaml

@@ -5,38 +5,36 @@ metadata:
   name: registeredlimit-dependency
 spec:
   cloudCredentialsRef:
-    # TODO(scaffolding): Use openstack-admin if the resource needs admin credentials to be created
-    cloudName: openstack
+    cloudName: openstack-admin
     secretName: openstack-clouds
   managementPolicy: managed
-  # TODO(scaffolding): Add the necessary fields to create the resource
-  resource: {}
+  resource:
+    type: registeredlimit-test
 ---
 apiVersion: openstack.k-orc.cloud/v1alpha1
 kind: RegisteredLimit
 metadata:
   name: registeredlimit-dependency-no-service
 spec:
   cloudCredentialsRef:
-    # TODO(scaffolding): Use openstack-admin if the resource needs admin credentials to be created
-    cloudName: openstack
+    cloudName: openstack-admin
     secretName: openstack-clouds
   managementPolicy: managed
   resource:
     serviceRef: registeredlimit-dependency-pending
-    # TODO(scaffolding): Add the necessary fields to create the resource
-
+    resourceName: vcpus
+    defaultLimit: 5
 ---
 apiVersion: openstack.k-orc.cloud/v1alpha1
 kind: RegisteredLimit
 metadata:
   name: registeredlimit-dependency-no-secret
 spec:
   cloudCredentialsRef:
-    # TODO(scaffolding): Use openstack-admin if the resource needs admin credentials to be created
-    cloudName: openstack
+    cloudName: openstack-admin
     secretName: registeredlimit-dependency
   managementPolicy: managed
-  # TODO(scaffolding): Add the necessary fields to create the resource
   resource:
     serviceRef: registeredlimit-dependency
+    resourceName: vcpus
+    defaultLimit: 5

internal/controllers/registeredlimit/tests/registeredlimit-dependency/01-create-dependencies.yaml

@@ -11,9 +11,8 @@ metadata:
   name: registeredlimit-dependency-pending
 spec:
   cloudCredentialsRef:
-    # TODO(scaffolding): Use openstack-admin if the resource needs admin credentials to be created
-    cloudName: openstack
+    cloudName: openstack-admin
     secretName: openstack-clouds
   managementPolicy: managed
-  # TODO(scaffolding): Add the necessary fields to create the resource
-  resource: {}
+  resource:
+    type: registeredlimit-test

internal/controllers/registeredlimit/tests/registeredlimit-import-error/00-create-resources.yaml

@@ -5,39 +5,38 @@ metadata:
   name: registeredlimit-import-error
 spec:
   cloudCredentialsRef:
-    # TODO(scaffolding): Use openstack-admin if the resource needs admin credentials to be created
-    cloudName: openstack
+    cloudName: openstack-admin
     secretName: openstack-clouds
   managementPolicy: managed
-  # TODO(scaffolding): Add the necessary fields to create the resource
-  resource: {}
+  resource:
+    type: registeredlimit-import-error
 ---
 apiVersion: openstack.k-orc.cloud/v1alpha1
 kind: RegisteredLimit
 metadata:
   name: registeredlimit-import-error-external-1
 spec:
   cloudCredentialsRef:
-    # TODO(scaffolding): Use openstack-admin if the resource needs admin credentials to be created
-    cloudName: openstack
+    cloudName: openstack-admin
     secretName: openstack-clouds
   managementPolicy: managed
   resource:
     description: RegisteredLimit from "import error" test
     serviceRef: registeredlimit-import-error
-    # TODO(scaffolding): add any required field
+    resourceName: vcpus
+    defaultLimit: 5
 ---
 apiVersion: openstack.k-orc.cloud/v1alpha1
 kind: RegisteredLimit
 metadata:
   name: registeredlimit-import-error-external-2
 spec:
   cloudCredentialsRef:
-    # TODO(scaffolding): Use openstack-admin if the resource needs admin credentials to be created
-    cloudName: openstack
+    cloudName: openstack-admin
     secretName: openstack-clouds
   managementPolicy: managed
   resource:
     description: RegisteredLimit from "import error" test
     serviceRef: registeredlimit-import-error
-    # TODO(scaffolding): add any required field
+    resourceName: vcpus
+    defaultLimit: 12

internal/controllers/registeredlimit/tests/registeredlimit-import-error/01-import-resource.yaml

@@ -5,9 +5,9 @@ metadata:
   name: registeredlimit-import-error
 spec:
   cloudCredentialsRef:
-    cloudName: openstack
+    cloudName: openstack-admin
     secretName: openstack-clouds
   managementPolicy: unmanaged
   import:
     filter:
-      description: RegisteredLimit from "import error" test
+      resourceName: vcpus

internal/controllers/registeredlimit/tests/registeredlimit-import/00-import-resource.yaml

@@ -1,15 +1,28 @@
 ---
 apiVersion: openstack.k-orc.cloud/v1alpha1
+kind: Service
+metadata:
+  name: registeredlimit-import
+spec:
+  cloudCredentialsRef:
+    cloudName: openstack-admin
+    secretName: openstack-clouds
+  managementPolicy: unmanaged
+  import:
+    filter:
+      type: compute
+---
+apiVersion: openstack.k-orc.cloud/v1alpha1
 kind: RegisteredLimit
 metadata:
   name: registeredlimit-import
 spec:
   cloudCredentialsRef:
-    cloudName: openstack
+    cloudName: openstack-admin
     secretName: openstack-clouds
   managementPolicy: unmanaged
   import:
     filter:
-      name: registeredlimit-import-external
       description: RegisteredLimit registeredlimit-import-external from "registeredlimit-import" test
-      # TODO(scaffolding): Add all fields supported by the filter
+      serviceRef: registeredlimit-import
+      resourceName: vcpus