Skip to content

Commit 9b0a8e9

Browse files
committed
Address PR review comments
Fix parameters in dependencies in Limit actuator Fix default name in test utils
1 parent 7d4b66f commit 9b0a8e9

2 files changed

Lines changed: 8 additions & 8 deletions

File tree

internal/controllers/limit/actuator.go

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -85,23 +85,23 @@ func (actuator limitActuator) ListOSResourcesForAdoption(ctx context.Context, or
8585
return orcv1alpha1.IsAvailable(dep) && dep.Status.ID != nil
8686
},
8787
)
88-
rs.WithReconcileStatus(rs1)
88+
rs = rs.WithReconcileStatus(rs1)
8989

9090
project, rs1 := dependency.FetchDependency(
91-
ctx, actuator.k8sClient, orcObject.Namespace, &resourceSpec.ServiceRef, "Project",
92-
func(dep *orcv1alpha1.Service) bool {
91+
ctx, actuator.k8sClient, orcObject.Namespace, resourceSpec.ProjectRef, "Project",
92+
func(dep *orcv1alpha1.Project) bool {
9393
return orcv1alpha1.IsAvailable(dep) && dep.Status.ID != nil
9494
},
9595
)
96-
rs.WithReconcileStatus(rs1)
96+
rs = rs.WithReconcileStatus(rs1)
9797

9898
domain, rs1 := dependency.FetchDependency(
99-
ctx, actuator.k8sClient, orcObject.Namespace, &resourceSpec.ServiceRef, "Domain",
100-
func(dep *orcv1alpha1.Service) bool {
99+
ctx, actuator.k8sClient, orcObject.Namespace, resourceSpec.DomainRef, "Domain",
100+
func(dep *orcv1alpha1.Domain) bool {
101101
return orcv1alpha1.IsAvailable(dep) && dep.Status.ID != nil
102102
},
103103
)
104-
rs.WithReconcileStatus(rs1)
104+
rs = rs.WithReconcileStatus(rs1)
105105

106106
if needsReschedule, err := rs.NeedsReschedule(); needsReschedule {
107107
if err != nil {

internal/controllers/limit/tests/utils/main.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -42,7 +42,7 @@ func main() {
4242

4343
podName := os.Getenv("POD_NAME")
4444
if podName == "" {
45-
namespace = "default"
45+
podName = "default"
4646
}
4747

4848
testCase := os.Getenv("TEST_CASE")

0 commit comments

Comments
 (0)