Skip to content

Commit c416088

Browse files
committed
Fix warnings from golint and kubeapilinter
1 parent 9695342 commit c416088

8 files changed

Lines changed: 33 additions & 3 deletions

File tree

api/v1alpha1/limit_types.go

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -29,7 +29,7 @@ type LimitResourceSpec struct {
2929
// serviceRef is a reference to the ORC Service which this resource is associated with.
3030
// +required
3131
// +kubebuilder:validation:XValidation:rule="self == oldSelf",message="serviceRef is immutable"
32-
ServiceRef KubernetesNameRef `json:"serviceRef"`
32+
ServiceRef KubernetesNameRef `json:"serviceRef,omitempty"`
3333

3434
// projectRef is a reference to the ORC Project which this resource is associated with.
3535
// Either Domain ID or Project ID must be provided.
@@ -51,7 +51,7 @@ type LimitResourceSpec struct {
5151
// +kubebuilder:validation:Pattern=`^[\S]+$`
5252
// +required
5353
// +kubebuilder:validation:XValidation:rule="self == oldSelf",message="resourceName is immutable"
54-
ResourceName string `json:"resourceName"`
54+
ResourceName string `json:"resourceName,omitempty"`
5555

5656
// resourceLimit is the override value of the limit.
5757
// +kubebuilder:validation:Minimum=-1

api/v1alpha1/zz_generated.deepcopy.go

Lines changed: 5 additions & 0 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

cmd/models-schema/zz_generated.openapi.go

Lines changed: 7 additions & 0 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

config/crd/bases/openstack.k-orc.cloud_limits.yaml

Lines changed: 5 additions & 0 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

internal/controllers/limit/tests/utils/main.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -60,7 +60,7 @@ func main() {
6060
if err != nil {
6161
panic(err)
6262
}
63-
defer f.Close()
63+
defer f.Close() //nolint:errcheck
6464

6565
slog.SetDefault(slog.New(slog.NewTextHandler(io.MultiWriter(os.Stderr, f), nil)).With("podName", podName))
6666

pkg/clients/applyconfiguration/api/v1alpha1/limitfilter.go

Lines changed: 9 additions & 0 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

pkg/clients/applyconfiguration/internal/internal.go

Lines changed: 3 additions & 0 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

website/docs/crd-reference.md

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2280,6 +2280,7 @@ _Appears in:_
22802280

22812281
| Field | Description | Default | Validation |
22822282
| --- | --- | --- | --- |
2283+
| `description` _string_ | description of the existing resource | | MaxLength: 255 <br />MinLength: 1 <br />Optional: \{\} <br /> |
22832284
| `serviceRef` _[KubernetesNameRef](#kubernetesnameref)_ | serviceRef is a reference to the ORC Service which this resource is associated with. | | MaxLength: 253 <br />MinLength: 1 <br />Optional: \{\} <br /> |
22842285
| `projectRef` _[KubernetesNameRef](#kubernetesnameref)_ | projectRef is a reference to the ORC Project which this resource is associated with. | | MaxLength: 253 <br />MinLength: 1 <br />Optional: \{\} <br /> |
22852286
| `domainRef` _[KubernetesNameRef](#kubernetesnameref)_ | domainRef is a reference to the ORC Domain which this resource is associated with. | | MaxLength: 253 <br />MinLength: 1 <br />Optional: \{\} <br /> |

0 commit comments

Comments
 (0)