Region Tests and Config Samples

On-behalf-of: SAP nils.gondermann@sap.com

Author: gndrmnn

config/samples/openstack_v1alpha1_region.yaml

@@ -5,10 +5,9 @@ metadata:
   name: region-sample
 spec:
   cloudCredentialsRef:
-    # TODO(scaffolding): Use openstack-admin if the resource needs admin credentials to be created
-    cloudName: openstack
+    cloudName: openstack-admin
     secretName: openstack-clouds
   managementPolicy: managed
   resource:
+    name: SampleRegion
     description: Sample Region
-    # TODO(scaffolding): Add all fields the resource supports

internal/controllers/region/tests/region-create-full/00-assert.yaml

@@ -7,7 +7,6 @@ status:
   resource:
     name: region-create-full-override
     description: Region from "create full" test
-    # TODO(scaffolding): Add all fields the resource supports
   conditions:
   - type: Available
     status: "True"
@@ -25,4 +24,4 @@ resourceRefs:
       ref: region
 assertAll:
     - celExpr: "region.status.id != ''"
-    # TODO(scaffolding): Add more checks
+    - celExpr: "region.status.id == region.status.resource.name"

internal/controllers/region/tests/region-create-full/00-create-resource.yaml

@@ -5,11 +5,9 @@ metadata:
   name: region-create-full
 spec:
   cloudCredentialsRef:
-    # TODO(scaffolding): Use openstack-admin if the resource needs admin credentials to be created
-    cloudName: openstack
+    cloudName: openstack-admin
     secretName: openstack-clouds
   managementPolicy: managed
   resource:
     name: region-create-full-override
     description: Region from "create full" test
-    # TODO(scaffolding): Add all fields the resource supports

internal/controllers/region/tests/region-create-minimal/00-assert.yaml

@@ -5,8 +5,7 @@ metadata:
   name: region-create-minimal
 status:
   resource:
-    name: region-create-minimal
-    # TODO(scaffolding): Add all fields the resource supports
+    name: TestRegion
   conditions:
   - type: Available
     status: "True"
@@ -24,4 +23,4 @@ resourceRefs:
       ref: region
 assertAll:
     - celExpr: "region.status.id != ''"
-    # TODO(scaffolding): Add more checks
+    - celExpr: "region.status.id == region.status.resource.name"

internal/controllers/region/tests/region-create-minimal/00-create-resource.yaml

@@ -5,10 +5,8 @@ metadata:
   name: region-create-minimal
 spec:
   cloudCredentialsRef:
-    # TODO(scaffolding): Use openstack-admin if the resource needs admin credentials to be created
-    cloudName: openstack
+    cloudName: openstack-admin
     secretName: openstack-clouds
   managementPolicy: managed
-  # TODO(scaffolding): Only add the mandatory fields. It's possible the resource
-  # doesn't have mandatory fields, in that case, leave it empty.
-  resource: {}
+  resource:
+    name: TestRegion

internal/controllers/region/tests/region-import-error/00-create-resources.yaml

@@ -5,24 +5,22 @@ metadata:
   name: region-import-error-external-1
 spec:
   cloudCredentialsRef:
-    # TODO(scaffolding): Use openstack-admin if the resource needs admin credentials to be created
-    cloudName: openstack
+    cloudName: openstack-admin
     secretName: openstack-clouds
   managementPolicy: managed
   resource:
+    name: region-import-error-external-1
     description: Region from "import error" test
-    # TODO(scaffolding): add any required field
 ---
 apiVersion: openstack.k-orc.cloud/v1alpha1
 kind: Region
 metadata:
   name: region-import-error-external-2
 spec:
   cloudCredentialsRef:
-    # TODO(scaffolding): Use openstack-admin if the resource needs admin credentials to be created
-    cloudName: openstack
+    cloudName: openstack-admin
     secretName: openstack-clouds
   managementPolicy: managed
   resource:
+    name: region-import-error-external-2
     description: Region from "import error" test
-    # TODO(scaffolding): add any required field

internal/controllers/region/tests/region-import-error/01-import-resource.yaml

@@ -5,7 +5,7 @@ metadata:
   name: region-import-error
 spec:
   cloudCredentialsRef:
-    cloudName: openstack
+    cloudName: openstack-admin
     secretName: openstack-clouds
   managementPolicy: unmanaged
   import:

internal/controllers/region/tests/region-import/00-import-resource.yaml

@@ -5,11 +5,10 @@ metadata:
   name: region-import
 spec:
   cloudCredentialsRef:
-    cloudName: openstack
+    cloudName: openstack-admin
     secretName: openstack-clouds
   managementPolicy: unmanaged
   import:
     filter:
       name: region-import-external
       description: Region region-import-external from "region-import" test
-      # TODO(scaffolding): Add all fields supported by the filter

internal/controllers/region/tests/region-import/01-assert.yaml

@@ -16,7 +16,6 @@ status:
   resource:
     name: region-import-external-not-this-one
     description: Region region-import-external from "region-import" test
-    # TODO(scaffolding): Add fields necessary to match filter
 ---
 apiVersion: openstack.k-orc.cloud/v1alpha1
 kind: Region

internal/controllers/region/tests/region-import/01-create-trap-resource.yaml

@@ -8,10 +8,9 @@ metadata:
   name: region-import-external-not-this-one
 spec:
   cloudCredentialsRef:
-    # TODO(scaffolding): Use openstack-admin if the resource needs admin credentials to be created
-    cloudName: openstack
+    cloudName: openstack-admin
     secretName: openstack-clouds
   managementPolicy: managed
   resource:
+    name: region-import-external-not-this-one
     description: Region region-import-external from "region-import" test
-    # TODO(scaffolding): Add fields necessary to match filter