some input buffers cause sherpa onnx diarization to crash with 0xC0000005

[philipag]

The attached sample shows the crash with the second call to Process(). It is the specific input audio buffer that causes the crash and happens with any provider.

Exception thrown at 0x00007FFB3CFEBEE1 (sherpa-onnx-c-api.dll) in xxx: 0xC0000005: Access violation reading location 0x0000000000000000

SherpaCrash.zip

[philipag]

In addition to the attached sample, I am occasionally getting access violations when computing embeddings in code like this:

		var stream = emb.CreateStream();
		stream.AcceptWaveform((int)SpeakerSampleRate, samples);
		stream.InputFinished();

		// Crash here
		var embedding = emb.Compute(stream);

Unfortunately I was unable to capture those less frequent crashes in a sample, but perhaps this means that the underlying crash I reported is caused by the embedding calculation.

[csukuangfj]

  stream.AcceptWaveform((int)SpeakerSampleRate, samples);

What is the size of samples? Is it to short?

[philipag]

@csukuangfj In the case of the embedding calculation there were only 380 samples so not a realistic example. But re-running on the same captured buffer did not cause a crash so there must have been something about the state. The reason for the short buffer is what appears to be another bug which is that diarization returns segments which span well past the end of the audio input buffer. In this case I truncated the segment and computed embedding on the truncated segment which ended up being very short. If you like I can try to produce a sample which shows this "segment extends past end of input audio buffer" bug. It happens quite frequently so you could probably see this on any diarization streaming sample...

Note that I am computing these over thousands of hours of audio and only a very small fraction of input buffers cause these problems.

[csukuangfj]

Please try to find the size of the samples that causes the crash.

[philipag]

This is the exact buffer that cause the crash in emb.Compute():

		float[] crashData =
			{
				0.01269106F, 0.0181304365F, 0.0126915509F, 0.009065568F, 0.00566608971F, 0.00113323983F, 0.00362643762F, 0.00385316415F, 0.00634651026F, 0.004533309F, 0.00408005668F, -0.001360045F, 0.0004533571F, 0.00294687785F, 0.00362699642F,
				0.00362706627F, 0.00385383214F, 0.000453400746F, 0.005214209F, 0.00249380013F, 0.00181370764F, 0.003627485F, 0.00385427661F, -0.003174171F, -0.00272077043F, -0.00476143928F, 0.00317435386F, -0.000906975649F, 0.00158723781F,
				0.00453505246F, 0.0031745974F, 0.003628181F, -0.00294795376F, -0.00340155F, -0.009297748F, -0.000226778677F, 0.00317496224F, 0.00226787338F, -0.000907166745F, 0.00317514432F, -0.000226800359F, -0.00725775026F, -0.00476298947F,
				-0.00317538716F, -0.002268177F, -0.00158775435F, 0.0006804791F, 0.0018146456F, -0.00158784515F, 0.00317575084F, 0.00249528023F, 0.001587936F, 0.006578717F, -0.000226856631F, -0.00181488763F, -0.000226865275F, -0.00249556545F,
				-0.005898722F, -0.00499132136F, 0.00453765132F, 0.00453773746F, 0.00363025884F, 0.000226895485F, 0.00521869538F, 0.00408427371F, 0.004538168F, 0.00136147626F, 0.00567292562F, 0.005673033F, 0.004311587F, 0.00181543955F,
				0.0004538685F, -0.00703509524F, -0.00272331433F, 0.00680841459F, -0.00272341748F, -0.00385824777F, -0.00431224052F, -0.00839768F, -0.009078745F, -0.00680918759F, -0.0115758376F, -0.0131649273F, -0.0115762753F, -0.0113495048F,
				-0.00136196625F, -0.00385897746F, 0.00272403541F, -0.00227007223F, 0.001362069F, 0.004086284F, 0.0129401432F, 0.007945852F, -0.000454057241F, -0.00544878934F, 0.000681111531F, -0.000227041455F, 0.000454091467F, -0.000227050012F,
				0.00136232574F, 0.00136235147F, -0.00158943981F, 0.0002270671F, -0.00204364234F, 0.00249783183F, -0.000908319547F, 0.0009083366F, 0.000454176828F, -0.00272511225F, -0.009765169F, -0.00567753F, -0.003406582F, -0.00545063335F,
				-0.00113557F, -0.00249830075F, -0.0006813675F, -0.00431540841F, -0.001362786F, -0.0015899468F, 0.0002271395F, 0F, -0.000227148F, -0.000908609F, -0.000454313F, -0.001817286F, -0.002498815F, -0.00249886187F, -0.00567933731F,
				-0.01499373F, -0.0143124638F, -0.009087448F, -0.0134042362F, -0.0184027683F, -0.0113599449F, -0.008406516F, -0.00954271F, -0.008861253F, -0.009315849F, -0.008179923F, -0.006589505F, -0.0104525136F, -0.0145428982F, -0.01136185F,
				-0.0093168905F, -0.008408082F, -0.00659024F, -0.00727212429F, -0.00704500126F, -0.005681558F, -0.00431806454F, -0.006590852F, -0.00954555F, -0.0184096154F, -0.0156825557F, -0.009773369F, -0.005455005F, -0.0006818882F, -0.0061371075F,
				-0.0036368717F, -0.00250039552F, -0.00363700627F, -0.002500488F, -0.00454642624F, -0.00181860407F, -0.0059105726F, -0.00409201067F, -0.006138129F, -0.008639009F, -0.01250406F, -0.007047873F, -0.007502713F, -0.00522926F, -0.0047746296F,
				-0.00522945262F, 0.00181897357F, 0.006366525F, 0.00750354258F, 0.008640602F, 0.005002546F, 0F, 0.004093143F, 0.0020466093F, 0.007049562F, 0.008868967F, 0.0168286059F, 0.00727736857F, 0.0168292243F, 0.02410717F, 0.0136458175F, 0.0102345515F,
				0.0111444937F, 0.0109172557F, 0.0129644787F, 0.0097804F, 0.008415848F, 0.005231569F, 0.008188694F, 0.007961376F, 0.009781298F, 0.007961667F, 0.007506852F, 0.007279505F, 0.006824661F, 0.008417236F, 0.008644886F, 0.00568752969F, 0.008645203F,
				0.006825285F, 0.005460328F, 0.004095321F, 0.00500548352F, -0.00341289234F, -0.0179748926F, -0.0182027556F, -0.0104667749F, -0.010922052F, -0.0154731879F, -0.0213897973F, -0.0150186419F, -0.0195701029F, -0.0266249273F, -0.0232118983F,
				-0.03094976F, -0.0275366865F, -0.0327715278F, -0.0252618473F, -0.02207607F, -0.0204833224F, -0.0188905187F, -0.0177528579F, -0.0109250341F, -0.00341413519F, -0.00660078134F, -0.009332309F, -0.0025038356F, 0.00273150648F, 0.002731556F,
				0.007967183F, 0.00500803441F, 0.0006829262F, 0.005918801F, -0.000910601229F, 0.00273185316F, 0.000682975631F, 0.005236241F, -0.00113833393F, 0.0015936963F, -0.00318745F, 0.000910716539F, 0.0004553665F, 0.00432606F, 0.00159384042F, 0.00660317251F,
				0.009107989F, 0.0163946748F, 0.00592040643F, 0.006603649F, 0.0163955614F, 0.0216334239F, 0.0127525637F, 0.007515039F, 0.0141194183F, 0.00569341658F, 0.0104760751F, 0.00136646919F, 0.00318848551F, 0.0132096782F, 0.0134376734F, 0.0118435854F, 0.007060726F, 0.0109329335F,
				0.00614988524F, 0.0154888779F, 0.01594472F, 0.0127560049F, 0.0111617045F, 0.008883965F, 0.00478375936F, 0.002733626F, 0.00911225F, -0.002733724F, -0.00296158763F, -0.000455637F, 0.008429435F, 0.00501218624F, -0.00205047661F, 0.0002278348F,
				0.00797436F, 0.005012545F, -0.00296201138F, -0.005696277F, -0.009342062F, -0.00227859244F, -0.00455726637F, -0.007063889F, -0.00774762966F, 0.005924764F, 0.00364607363F, 0.0104826484F, 0.0038740912F, -0.00296259322F, -0.007976354F, -0.00752069661F,
				-0.0145858536F, -0.0102558611F, -0.0113956043F, 0.0006837484F, 0.00273504248F, 0.00638187956F, 0.00752163446F, 0.0123083489F, 0.009801267F, 0.0100293811F, -0.0020515006F, -0.003647177F, 0.00136771565F, -0.00273547973F, 0.0474158265F, 0.0918697938F,
				0.102130018F, -0.157073289F, -0.0506108664F, -0.0458241664F, -0.104417115F, -0.0588211678F, -0.09461711F, -0.0237116963F, -0.0702243447F, -0.0289566536F, -0.0647546053F, -0.027133571F, -0.0430952571F, -0.01618951F, -0.03055539F, -0.007981027F, -0.0150502017F, -0.009121495F,
				-0.0180152729F, -0.0145949088F, -0.0184720084F, -0.0187003873F, -0.0234899241F, -0.0127714453F, -0.0259994715F, -0.02007012F, -0.0228073578F, -0.0141408108F, -0.0202992633F, -0.0150536513F, -0.01870335F
			};

[csukuangfj]

Can you show the size of the samples?

We need to know the duration.

[philipag]

I don't know exactly where this set of samples came from. But in the crash sample I uploaded I embedded a larger sample buffer which does cause a crash every time so perhaps that would be better to work off of.

[csukuangfj]

Can you show the size of the samples?

We need to know the duration.

Can you answer it?

[philipag]

float[] crashData that crashed emb.Compute(stream) is of length 350. It is the array of floats I posted above. But as I said I cannot repeat the crash by just passing that buffer. The crash happened after streaming many more samples and I don't know where in time this happened so I cannot retrieve surrounding buffers.

However, in my first post I included a sample project which does crash every time, so it might be best to fix that first since it might fix the emb.Compute(stream) crash as well?

So just to be clear there are 3 issues which may be related:

1. Invalid memory access I reported first (diarization crash with sample so should be easy to fix).
2. Invalid memory access caused by emb.Compute(stream) and the float[350] buffer I posted above (not easily repeatable and does not crash on just that float[350] buffer so not easy to fix.
3. The reason for the float[350] buffer is that diarization returns segments which span past the end of the input buffer. I can probably make a sample project that reproduces this.

[csukuangfj]

is of length 350.

When the sample rate is 16000, it means you use

350 / 16000 = 0.021875 seconds

of data to compute the embedding. I am not sure what features it can compute for such a short audio.

Would you mind filtering shorter audios, e.g., shorter than 1 second and retry?

[philipag]

I already do that now to avoid the crashes and since these short samples don't make sense. I think the only crash worth fixing at the moment is the sample I uploaded in the first post. Then I can run through the data again to see if there are anymore crashes.

[philipag]

@csukuangfj In the SherpaCrash.zip file I uploaded there is the TestData.cs file which contains a much longer buffer of many seconds which causes a crash...

[csukuangfj]

Could you tell us the exact number of seconds?