Skip to content

Commit 91aaf58

Browse files
Uninstall of helm chart fails (#22)
* Updated entry to correct logic for upgrade of helm charts Signed-off-by: Gaurav Mehta <gaurav@rancher.com> * fixes and signoff Signed-off-by: Gaurav Mehta <gaurav@rancher.com>
1 parent 0ff8c06 commit 91aaf58

1 file changed

Lines changed: 3 additions & 3 deletions

File tree

entry

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@
22

33
helm_update() {
44
if [ "$HELM" == "helm_v3" ]; then
5-
LINE="$($HELM ls --all-namespaces --all -f "^$NAME\$" --output json | jq -r "$JQ_CMD" | tr '[:upper:]' '[:lower:]')"
5+
LINE="$($HELM ls -f "^$NAME\$" --namespace $TARGET_NAMESPACE --output json | jq -r "$JQ_CMD" | tr '[:upper:]' '[:lower:]')"
66
else
77
LINE="$($HELM ls --all "^$NAME\$" --output json | jq -r "$JQ_CMD" | tr '[:upper:]' '[:lower:]')"
88
fi
@@ -19,7 +19,7 @@ helm_update() {
1919
exit
2020
fi
2121
if [ "$HELM" == "helm_v3" ]; then
22-
$HELM uninstall $NAME || true
22+
$HELM uninstall $NAME --namespace $TARGET_NAMESPACE|| true
2323
else
2424
$HELM delete $NAME || true
2525
$HELM "$@" --purge $NAME
@@ -42,7 +42,7 @@ helm_update() {
4242

4343
if [ "$STATUS" = "failed" ] || [ "$STATUS" = "deleted" ]; then
4444
if [ "$HELM" == "helm_v3" ]; then
45-
$HELM uninstall $NAME
45+
$HELM uninstall $NAME --namespace $TARGET_NAMESPACE
4646
else
4747
$HELM "$@" --purge $NAME
4848
fi

0 commit comments

Comments
 (0)