Fix: Pass filters as command-line arguments to k8sgpt serve command (#762)

* Initial plan

* Fix: Pass filters as arguments to k8sgpt serve command

- Modified GetDeployment to use buildK8sGPTArgs helper function
- buildK8sGPTArgs now includes --filter args for each specified filter
- Added comprehensive test coverage for filter functionality
- This fixes the issue where Deployment resources were not generating Results

Co-authored-by: AlexsJones <1235925+AlexsJones@users.noreply.github.com>

* Apply go fmt to format code properly

Co-authored-by: AlexsJones <1235925+AlexsJones@users.noreply.github.com>

---------

Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
Co-authored-by: AlexsJones <1235925+AlexsJones@users.noreply.github.com>

Author: Copilot

pkg/resources/k8sgpt.go

@@ -244,6 +244,20 @@ func GetClusterRole(config v1alpha1.K8sGPT, serviceAccountName string) (*v1.Clus
 	return clusterRole, nil
 }
 
+// buildK8sGPTArgs builds the command-line arguments for the k8sgpt serve command
+func buildK8sGPTArgs(config v1alpha1.K8sGPT) []string {
+	args := []string{"serve"}
+
+	// Add filters if specified
+	if len(config.Spec.Filters) > 0 {
+		for _, filter := range config.Spec.Filters {
+			args = append(args, "--filter", filter)
+		}
+	}
+
+	return args
+}
+
 // GetDeployment Create deployment with the latest K8sGPT image
 func GetDeployment(config v1alpha1.K8sGPT, outOfClusterMode bool, c client.Client,
 	serviceAccountName string) (*appsv1.Deployment, error) {
@@ -286,9 +300,7 @@ func GetDeployment(config v1alpha1.K8sGPT, outOfClusterMode bool, c client.Clien
 							Name:            "k8sgpt",
 							ImagePullPolicy: config.Spec.ImagePullPolicy,
 							Image:           image,
-							Args: []string{
-								"serve",
-							},
+							Args:            buildK8sGPTArgs(config),
 							Env: []corev1.EnvVar{
 								{
 									Name:  "K8SGPT_MODEL",

pkg/resources/k8sgpt_test.go

@@ -272,3 +272,72 @@ func Test_GetDeploymentWithKubeconfigAndIRSA(t *testing.T) {
 		})
 	}
 }
+
+func Test_GetDeploymentWithFilters(t *testing.T) {
+	scheme := runtime.NewScheme()
+	require.NoError(t, appsv1.AddToScheme(scheme))
+	require.NoError(t, v1.AddToScheme(scheme))
+	fakeClient := fake.NewClientBuilder().WithScheme(scheme).Build()
+
+	testCases := []struct {
+		name         string
+		filters      []string
+		expectedArgs []string
+	}{
+		{
+			name:         "No filters specified",
+			filters:      []string{},
+			expectedArgs: []string{"serve"},
+		},
+		{
+			name:         "Single filter",
+			filters:      []string{"Pod"},
+			expectedArgs: []string{"serve", "--filter", "Pod"},
+		},
+		{
+			name:         "Multiple filters including Deployment",
+			filters:      []string{"Pod", "Deployment", "Service"},
+			expectedArgs: []string{"serve", "--filter", "Pod", "--filter", "Deployment", "--filter", "Service"},
+		},
+		{
+			name:         "All common filters",
+			filters:      []string{"Pod", "Deployment", "StatefulSet", "DaemonSet", "Service", "Ingress"},
+			expectedArgs: []string{"serve", "--filter", "Pod", "--filter", "Deployment", "--filter", "StatefulSet", "--filter", "DaemonSet", "--filter", "Service", "--filter", "Ingress"},
+		},
+	}
+
+	for _, tc := range testCases {
+		t.Run(tc.name, func(t *testing.T) {
+			config := v1alpha1.K8sGPT{
+				TypeMeta: metav1.TypeMeta{
+					Kind:       "K8sGPT",
+					APIVersion: "core.k8sgpt.ai/v1alpha1",
+				},
+				ObjectMeta: metav1.ObjectMeta{
+					Name:      "test-k8sgpt",
+					Namespace: "test-namespace",
+					UID:       "test-uid",
+				},
+				Spec: v1alpha1.K8sGPTSpec{
+					Repository:      "ghcr.io/k8sgpt-ai/k8sgpt",
+					Version:         "v0.4.1",
+					ImagePullPolicy: v1.PullAlways,
+					Filters:         tc.filters,
+					AI: &v1alpha1.AISpec{
+						Backend:   "openai",
+						Model:     "gpt-4o-mini",
+						MaxTokens: "2048",
+						Topk:      "50",
+					},
+				},
+			}
+
+			deployment, err := GetDeployment(config, false, fakeClient, "test-sa")
+			require.NoError(t, err)
+
+			// Verify the args contain the expected values
+			assert.Equal(t, tc.expectedArgs, deployment.Spec.Template.Spec.Containers[0].Args,
+				"Expected args to match for filter configuration: %v", tc.filters)
+		})
+	}
+}