tests: Fix timing race in legacy ConfigMap upgrade test

The test for legacy ConfigMap migration was failing due to a timing race
condition. The MAC entry was becoming stale too quickly (after 1 minute)
before the test could verify the "occupied" state.

Changed the stale timeout from 1 minute to 3 minutes in
simulateSoonToBeStaleEntryInConfigMap() to give the test sufficient
time.

Signed-off-by: Ram Lavi <ralavi@redhat.com>

Author: RamLavi

tests/tests.go

@@ -431,8 +431,9 @@ func simulateSoonToBeStaleEntryInConfigMap(macAddress string) error {
 			vmWaitConfigMap.Data = map[string]string{}
 		}
 		// legacy configMap uses time.RFC3339 format timestamps
-		// This entry should go stale after 1 minute
-		vmWaitConfigMap.Data[macAddressDashes] = time.Now().Add(-waitTime + time.Minute).Format(time.RFC3339)
+		// This entry should go stale after 3 minutes
+		staleAfterDuration := 3 * time.Minute
+		vmWaitConfigMap.Data[macAddressDashes] = time.Now().Add(-waitTime + staleAfterDuration).Format(time.RFC3339)
 		return nil
 	})