Revise to fix lint errors and address if-statement complexity

Signed-off-by: William Zhao <[email protected]>

Author: wizhaoredhat

go.mod

@@ -16,6 +16,7 @@ require (
 	github.com/pkg/errors v0.9.1
 	github.com/stretchr/testify v1.10.0
 	github.com/vishvananda/netlink v1.3.0
+	golang.org/x/sys v0.31.0
 	google.golang.org/grpc v1.69.2
 	k8s.io/kubelet v0.32.0
 )
@@ -59,7 +60,6 @@ require (
 	golang.org/x/mod v0.20.0 // indirect
 	golang.org/x/net v0.38.0 // indirect
 	golang.org/x/oauth2 v0.23.0 // indirect
-	golang.org/x/sys v0.31.0 // indirect
 	golang.org/x/term v0.30.0 // indirect
 	golang.org/x/text v0.23.0 // indirect
 	golang.org/x/time v0.7.0 // indirect

pkg/netdevice/netResourcePool.go

@@ -103,40 +103,24 @@ func (rp *netResourcePool) Probe() bool {
 				}
 				cachedPfLinkStatus[pfName] = pfIsUp
 			}
-			pfIsUpLog = fmt.Sprintf("PF %s", pfName)
-			if pfIsUp {
-				pfIsUpLog = fmt.Sprintf("%s is UP, ", pfIsUpLog)
-			} else {
-				pfIsUpLog = fmt.Sprintf("%s is DOWN, ", pfIsUpLog)
-			}
+			pfIsUpLog = fmt.Sprintf("PF %s is %s,", pfName, map[bool]string{true: "Up", false: "Down"}[pfIsUp])
 		}
 
 		deviceExists := true
 		deviceExistsLog := ""
 		if rp.config.CheckHealthOnDeviceExist {
 			deviceExists = netDev.DeviceExists()
-			deviceExistsLog = fmt.Sprintf("Device %s", netDev.GetPciAddr())
-			if deviceExists {
-				deviceExistsLog = fmt.Sprintf("%s is existing, ", deviceExistsLog)
-			} else {
-				deviceExistsLog = fmt.Sprintf("%s is missing, ", deviceExistsLog)
-			}
+			deviceExistsLog = fmt.Sprintf("Device %s is %s,", netDev.GetPciAddr(),
+				map[bool]string{true: "existing", false: "missing"}[deviceExists])
 		}
 
 		if pfIsUp && deviceExists && !currentHealth {
-			glog.Infof("%s%sdevice was unhealthy, marking device %s as healthy", pfIsUpLog, deviceExistsLog, id)
+			glog.Infof("%s %s device was unhealthy, marking device %s as healthy", pfIsUpLog, deviceExistsLog, id)
 			device.SetHealth(true)
 			changes = true
-		} else if !pfIsUp && deviceExists && currentHealth {
-			glog.Infof("%s%sdevice was healthy, marking device %s as unhealthy", pfIsUpLog, deviceExistsLog, id)
-			device.SetHealth(false)
-			changes = true
-		} else if pfIsUp && !deviceExists && currentHealth {
-			glog.Infof("%s%sdevice was healthy, marking device %s as unhealthy", pfIsUpLog, deviceExistsLog, id)
-			device.SetHealth(false)
-			changes = true
-		} else if !pfIsUp && !deviceExists && currentHealth {
-			glog.Infof("%s%sdevice was healthy, marking device %s as unhealthy", pfIsUpLog, deviceExistsLog, id)
+		} else if (!pfIsUp || !deviceExists) && currentHealth {
+			// If either the PF is down or the device is missing:
+			glog.Infof("%s %s device was healthy, marking device %s as unhealthy", pfIsUpLog, deviceExistsLog, id)
 			device.SetHealth(false)
 			changes = true
 		}