Merge pull request #748 from SchSeba/allow_to_remove_default_pool

allow to remove a sriovPool named default

Author: adrianchiris

pkg/webhook/validate.go

@@ -96,10 +96,6 @@ func validateSriovNetworkPoolConfig(cr *sriovnetworkv1.SriovNetworkPoolConfig, o
 	log.Log.V(2).Info("validateSriovNetworkPoolConfig", "object", cr)
 	var warnings []string
 
-	if cr.GetName() == consts.DefaultConfigName && operation == v1.Delete {
-		return false, warnings, fmt.Errorf("default SriovOperatorConfig shouldn't be deleted")
-	}
-
 	if (cr.Spec.MaxUnavailable != nil || cr.Spec.NodeSelector != nil) && cr.Spec.OvsHardwareOffloadConfig.Name != "" {
 		return false, warnings, fmt.Errorf("SriovOperatorConfig can't have both parallel configuration and OvsHardwareOffloadConfig")
 	}

pkg/webhook/validate_test.go

@@ -229,8 +229,8 @@ func TestValidateSriovNetworkPoolConfigWithDefault(t *testing.T) {
 	snclient = fakesnclientset.NewSimpleClientset()
 
 	ok, _, err := validateSriovNetworkPoolConfig(config, "DELETE")
-	g.Expect(err).To(HaveOccurred())
-	g.Expect(ok).To(Equal(false))
+	g.Expect(err).ToNot(HaveOccurred())
+	g.Expect(ok).To(Equal(true))
 
 	ok, _, err = validateSriovNetworkPoolConfig(config, "UPDATE")
 	g.Expect(err).NotTo(HaveOccurred())