Skip to content

Commit 60c6404

Browse files
authored
Merge pull request #771 from zeeke/us/e2e-filter-devices
Refactor some conformance tests to use `SRIOV_NODE_AND_DEVICE_NAME_FILTER`
2 parents aecb4bb + 85feccd commit 60c6404

File tree

2 files changed

+11
-4
lines changed

2 files changed

+11
-4
lines changed

test/conformance/tests/test_sriov_operator.go

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1068,9 +1068,11 @@ var _ = Describe("[sriov] operator", func() {
10681068

10691069
findSriovDevice := func(vendorID, deviceID string) (string, sriovv1.InterfaceExt) {
10701070
for _, node := range sriovInfos.Nodes {
1071-
for _, nic := range sriovInfos.States[node].Status.Interfaces {
1071+
devices, err := sriovInfos.FindSriovDevices(node)
1072+
Expect(err).ToNot(HaveOccurred())
1073+
for _, nic := range devices {
10721074
if vendorID != "" && deviceID != "" && nic.Vendor == vendorID && nic.DeviceID == deviceID {
1073-
return node, nic
1075+
return node, *nic
10741076
}
10751077
}
10761078
}

test/util/cluster/cluster.go

Lines changed: 7 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -230,9 +230,14 @@ func (n *EnabledNodes) FindOneSriovNodeAndDevice() (string, *sriovv1.InterfaceEx
230230
// FindOneVfioSriovDevice retrieves a node with a valid sriov device for vfio
231231
func (n *EnabledNodes) FindOneVfioSriovDevice() (string, sriovv1.InterfaceExt) {
232232
for _, node := range n.Nodes {
233-
for _, nic := range n.States[node].Status.Interfaces {
233+
devices, err := n.FindSriovDevices(node)
234+
if err != nil {
235+
return "", sriovv1.InterfaceExt{}
236+
}
237+
238+
for _, nic := range devices {
234239
if nic.Vendor == intelVendorID && sriovv1.IsSupportedModel(nic.Vendor, nic.DeviceID) && nic.TotalVfs != 0 {
235-
return node, nic
240+
return node, *nic
236241
}
237242
}
238243
}

0 commit comments

Comments
 (0)