Prevent accidental IP deallocation in statefulsets #624
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
Author
|
@bpickard22, @thomasferrandiz, PTAL |
Pull Request Test Coverage Report for Build 16272872047Details
💛 - Coveralls |
This commit addresses a potential issue where IP allocations could be accidentally deleted when new pods with the same name and namespace are created in statefulset scenarios. The logic now correctly checks if a pod with the matching name and namespace exists and is not marked for deletion. If such a pod exists, the deallocation is skipped, preventing conflicts. The commit also includes clarified logging messages for improved debugging. Signed-off-by: Marcelo <[email protected]>
mlguerrero12
force-pushed
the
fixpodcontroller
branch
from
7d8e6a3 to
313ddf0
Compare
bpickard22
reviewed
Jul 14, 2025
|
|
||
| // The allocation could belong to a new pod with the same name and namespace. Stateful set scenarios. | ||
| // The previous pod should be gone by the time a pod deletion event is received. | ||
| if newPod, err := pc.k8sClient.CoreV1().Pods(podNamespace).Get(context.TODO(), podName, metav1.GetOptions{}); err == nil { |
Collaborator
There was a problem hiding this comment.
should we check if the pod is owned by a statefulset so we dont break the behavior for non stateful deployments?
Collaborator
There was a problem hiding this comment.
we can check the ownerref of the pod to see if it is part of a statefulset, if it is we release the ip, if not we proceed to use the existing logic
Collaborator
Author
There was a problem hiding this comment.
This doesn't apply to non stateful deployments. Pod name is different.
Collaborator
There was a problem hiding this comment.
@maiqueb we can assume the user is following naming conventions i guess
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit addresses a potential issue where IP allocations could be accidentally deleted when new pods with the same name and namespace are created in statefulset scenarios. The logic now correctly checks if a pod with the matching name and namespace exists and is not marked for deletion. If such a pod exists, the deallocation is skipped, preventing conflicts. The commit also includes clarified logging messages for improved debugging.