Skip to content

Task: make OP_MAKE_ADAPTER_SIG_PUBLIC and OP_MAKE_ADAPTER_SIG_PRIVATE pull stack arguments in consistent order #31

Description

@k98kurz

Task Description

OP_MAKE_ADAPTER_SIG_PUBLIC pulls the seed argument from the stack last while OP_MAKE_ADAPTER_SIG_PRIVATE pulls it from the stack first. The convention should be consistent for the two, and most likely this means the seed should be pulled first. It is hard to envision a use case where the order matters, but consistency will be an improvement.

  • Change OP_MAKE_ADAPTER_SIG_PUBLIC to pull its seed argument first
  • Update tests
  • Update docs

Metadata

Metadata

Assignees

Labels

documentationImprovements or additions to documentationtaskvm

Projects

No projects

Relationships

None yet

Development

No branches or pull requests

Issue actions