You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
@@ -25,13 +25,13 @@ Kaede is not even in a development stage yet. Check the [plan](./PLAN.md) to see
25
25
26
26
## Contributing
27
27
28
-
You don't need to know Rust to contribute to this project. Almost everything was written in TypeScript using Tauri API. These files will help you:
28
+
You don't need a Rust knowledge to contribute to this project. Almost everything was written in TypeScript using Tauri API. These files will help you:
29
29
30
30
-[README for JavaScript-related code](../src/README.md) (the most important one)
31
31
-[README for Rust-related code](../src-tauri/README.md)
32
32
-[Contributing Guidelines](./CONTRIBUTING.md)
33
33
34
-
I also add a lot of comments in the code.
34
+
I also leave a lot of comments in the code.
35
35
36
36
Pull requests are welcome. For major changes, please open an issue first to discuss what you would like to change.
37
37
@@ -44,7 +44,7 @@ Isolation was done using the [Secure ECMAScript](https://github.com/endojs/endo)
44
44
Interactive Live2Ds were taken from [Z_DK's Steam Workshop](https://steamcommunity.com/id/xingsuileixi/myworkshopfiles/?appid=431960)
45
45
46
46
<details>
47
-
We need to take care of DOM script tags that plugins can add when have the DOM access. Otherwise, this sandbox can be escaped. Maybe we can overwrite the `document.createElement` before freezing it? And just to be sure, listen for `head` element changes for possible script tag additions?
47
+
I need to take care of DOM script tags that plugins can add when have the DOM access. Otherwise, this sandbox can be escaped. Maybe I can overwrite the `document.createElement` before freezing it? And just to be sure, listen for `head` element changes for possible script tag additions?
48
48
49
49
Update: Seems like giving DOM access to the compartment basically ruins the whole purpose of plugin isolation, since one can add a JS code to any DOM element that will be executed in the global scope.
50
50
@@ -160,7 +160,7 @@ If you found a bug or want to suggest a feature, please open an issue in [GitHub
160
160
161
161
See [Tauri v2 Prerequisites](https://v2.tauri.app/start/prerequisites/).
162
162
163
-
We also recommend installing [bun](https://bun.sh/).
163
+
I also recommend installing [bun](https://bun.sh/).
0 commit comments