fix: handle infinity timeout for metadata request

Author: zmstone

src/wolff_client.erl

@@ -401,7 +401,7 @@ ensure_leader_connections2(#{metadata_conn := Pid,
                              conn_config := ConnConfig,
                              config := Config
                             } = St, Group, Topic, MaxPartitions) when is_pid(Pid) ->
-  Timeout = maps:get(request_timeout, ConnConfig, ?DEFAULT_METADATA_TIMEOUT),
+  Timeout = metadata_request_timeout(ConnConfig),
   IsAutoCreateAllowed = maps:get(allow_auto_topic_creation, Config, false),
   case do_get_metadata(Pid, Topic, Timeout, IsAutoCreateAllowed) of
     {ok, {Brokers, PartitionMetaList}} ->
@@ -596,7 +596,7 @@ get_metadata([], _ConnConfig, _Topic, _IsAutoCreateAllowed, Errors) ->
 get_metadata([Host | Rest], ConnConfig, Topic, IsAutoCreateAllowed, Errors) ->
   case do_connect(Host, ConnConfig) of
     {ok, Pid} ->
-      Timeout = maps:get(request_timeout, ConnConfig, ?DEFAULT_METADATA_TIMEOUT),
+      Timeout = metadata_request_timeout(ConnConfig),
       case do_get_metadata(Pid, Topic, Timeout, IsAutoCreateAllowed) of
         {ok, Result} ->
           {ok, {Pid, Result}};
@@ -770,3 +770,10 @@ bin(X) ->
         {error, _} -> bin(io_lib:format("~0p", [X]));
         Addr -> bin(Addr)
     end.
+
+metadata_request_timeout(#{request_timeout := infinity}) ->
+  ?DEFAULT_METADATA_TIMEOUT * 3;
+metadata_request_timeout(#{request_timeout := Timeout}) ->
+  Timeout;
+metadata_request_timeout(_) ->
+  ?DEFAULT_METADATA_TIMEOUT.

test/wolff_client_SUITE.erl

@@ -80,7 +80,7 @@ t_recv_leader_connection_with_auto_create_retry_success(Config) ->
     wolff_client:recv_leader_connection(Client, ?NO_GROUP, Topic, 0, self(), ?all_partitions),
     receive
       {leader_connection, Pid} when is_pid(Pid) ->
-        ?assert(is_pid(Pid));
+        true;
       {leader_connection, {down, Reason}} ->
         %% May get error if topic doesn't exist on real Kafka
         ?assertNotEqual(undefined, Reason)
@@ -141,24 +141,3 @@ client_config_with_auto_create() ->
   #{allow_auto_topic_creation => true,
     request_timeout => 2000
    }.
-
-client_config_without_auto_create() ->
-  #{allow_auto_topic_creation => false,
-    request_timeout => 1000
-   }.
-
-%% Helper function for meck mocking (similar to pattern used in other test files)
-with_meck(Mod, FnName, MockedFn, Action) ->
-  ok = meck:new(Mod, [non_strict, no_history, no_link, passthrough]),
-  ok = meck:expect(Mod, FnName, MockedFn),
-  try
-    Action()
-  after
-    meck:unload(Mod)
-  end.
-
-%% Helper function to create a mock connection for testing
-mock_connection() ->
-  %% Create a mock connection that can be used in tests
-  %% This is a simplified mock - in real tests you might want to use a more sophisticated mock
-  {mock_connection, self()}.