Skip to content

Commit 88539e9

Browse files
fix(helm): correct the ui.env description, and default it to a list
The comment described `ui.env` as key-value pairs for a ConfigMap. It is neither: `ui-deployment.yaml` splices it into the UI container's own `env:` list, so it takes `{name, value}` entries and reaches no ConfigMap. The default changes from `{}` to `[]` for the same reason — both are falsy to the `with` guard, so nothing renders differently, but the type is no longer misstated. This is the field an installed app extension's settings go in, so the note now says so. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Signed-off-by: Nicholas Bucher <behappy54321@gmail.com>
1 parent 9bf38e7 commit 88539e9

1 file changed

Lines changed: 5 additions & 1 deletion

File tree

helm/kagent/values.yaml

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -442,7 +442,11 @@ ui:
442442
proxyReadTimeout: 1800s
443443
# -- proxy_send_timeout: max time between two successive writes to the upstream.
444444
proxySendTimeout: 1800s
445-
env: {} # Additional configuration key-value pairs for the ui ConfigMap
445+
# -- Extra environment variables for the UI container, spliced into its `env:`
446+
# list verbatim. A list of `{name, value}` entries, not a map. An installed app
447+
# extension's own settings go here, named `EXTENSION_*`; the container's startup
448+
# script copies those onto `window.environmentVariables` for the browser to read.
449+
env: []
446450
# -- Identity headers the UI's nginx proxy will forward to the backend on
447451
# /api/ and /a2a/. Names are case-insensitive. Authorization is always
448452
# forwarded; the auth-proxy identity headers (x-auth-request-*, x-forwarded-user,

0 commit comments

Comments
 (0)