perf(scheduler): avoid synthetic partial search upper bound

Signed-off-by: Erez Freiberger <enoodle@gmail.com>

Author: enoodle

pkg/scheduler/actions/common/solvers/job_solver.go

@@ -210,7 +210,7 @@ func searchMaxSolvableK(n int, probe func(k int) *SearchResult) (int, *SearchRes
 	}
 
 	lo := 0
-	hi := n
+	var hi int
 	var lastUnsolvedResult *SearchResult
 	k := 1
 	for k < n {
@@ -226,8 +226,7 @@ func searchMaxSolvableK(n int, probe func(k int) *SearchResult) (int, *SearchRes
 		lo = k
 		k *= 2
 		if k >= n {
-			hi = n
-			break
+			return lo, lastUnsolvedResult
 		}
 	}
 

pkg/scheduler/actions/common/solvers/job_solver_test.go

@@ -17,9 +17,9 @@ func TestSearchMaxSolvableKSkipsFullProbe(t *testing.T) {
 		return solvedSearchResult(&solutionResult{solved: true}, false)
 	})
 
-	require.Equal(t, 3, maxSolvedK)
+	require.Equal(t, 2, maxSolvedK)
 	require.Nil(t, result)
-	require.Equal(t, []int{1, 2, 3}, probes)
+	require.Equal(t, []int{1, 2}, probes)
 }
 
 func TestSearchMaxSolvableKSkipsSingleTaskFullProbe(t *testing.T) {