Skip to content

Commit 62c0a8e

Browse files
committed
fix(podgrouper): match DynamoGraphDeployment on any served version
v0.16 registers the DGD at exact v1alpha1, but Dynamo 1.2.0+ serves and owns it as v1beta1. Required alongside the WorkloadRunner fix: granting podgrouper read access on dynamographdeployments lets the chain walk climb past the DGD instead of truncating there, so a v1beta1 DGD that misses the table now falls to the default grouper and flattens the gang. Matches the widening already on v0.17. Signed-off-by: gshaibi <gshaibi@nvidia.com>
1 parent 4eaba69 commit 62c0a8e

1 file changed

Lines changed: 2 additions & 1 deletion

File tree

  • pkg/podgrouper/podgrouper/hub

pkg/podgrouper/podgrouper/hub/hub.go

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -334,9 +334,10 @@ func NewDefaultPluginsHub(kubeClient client.Client, searchForLegacyPodGroups,
334334
}] = skipTopOwnerGrouper
335335

336336
// Dynamo uses Grove Grouper and needs to propagate metadata from DynamoGraphDeployment to PodGang and PodClique.
337+
// Match every served version: v1alpha1 (Dynamo <=1.1.x) and v1beta1 (1.2.0+, which serves/owns the DGD).
337338
table[metav1.GroupVersionKind{
338339
Group: "nvidia.com",
339-
Version: "v1alpha1",
340+
Version: "*",
340341
Kind: "DynamoGraphDeployment",
341342
}] = skipTopOwnerGrouper
342343

0 commit comments

Comments
 (0)