Skip to content

Commit 6d95dfd

Browse files
committed
.
Signed-off-by: gshaibi <gshaibi@nvidia.com>
1 parent b68d1b4 commit 6d95dfd

1 file changed

Lines changed: 0 additions & 18 deletions

File tree

pkg/podgrouper/integration_tests/workload_integration_test.go

Lines changed: 0 additions & 18 deletions
Original file line numberDiff line numberDiff line change
@@ -97,16 +97,6 @@ var _ = Describe("Workload API translation", func() {
9797
Expect(kerrors.IsNotFound(err)).To(BeTrue(), fmt.Sprintf("expected NotFound, got %v", err))
9898
})
9999

100-
// "Recovery on missing-then-present Workload" is intentionally NOT
101-
// covered here. controller-runtime's manager-cached client uses a
102-
// lazily-started unstructured informer for `getTopOwnerInstance`, which
103-
// races with the test-side pod creation in envtest and produces
104-
// transient `Pod not found` errors that swamp the 30s deadline. The
105-
// behaviour is exercised end-to-end by test/e2e/suites/workload, which
106-
// runs against a real apiserver where the cache stays warm. Soft-failure
107-
// classification (ErrWorkloadNotFound) is unit-tested in the workload
108-
// plugin package.
109-
110100
It("propagates a kai.scheduler/queue label from the Workload onto the KAI PodGroup", func(ctx context.Context) {
111101
const wlQueue = "ml-training"
112102
wl := &schedulingv1alpha1.Workload{
@@ -137,14 +127,6 @@ var _ = Describe("Workload API translation", func() {
137127
})
138128

139129
It("does not propagate Workload kai.scheduler/queue label changes to the existing PodGroup", func(ctx context.Context) {
140-
// Design contract (docs/developer/designs/k8s-workload-api/README.md,
141-
// "Workload mutation"): Spec.Queue is owned by the queue-assigner and
142-
// is intentionally not overwritten on update. ApplyOverride still
143-
// emits the Workload-derived Queue every reconcile, but
144-
// PodGroupHandler.ApplyToCluster's ignoreFields preserves the
145-
// existing Spec.Queue on update — the integration of the two is what
146-
// this test pins. Removing the guard in ignoreFields silently
147-
// breaks the contract; this test catches that regression.
148130
const initialQueue = "ml-training"
149131
const updatedQueue = "ml-batch"
150132
wl := &schedulingv1alpha1.Workload{

0 commit comments

Comments
 (0)