Skip to content

Commit c397fd9

Browse files
committed
style: trim remaining resize accounting comments
Signed-off-by: gshaibi <gshaibi@nvidia.com>
1 parent 1c04a72 commit c397fd9

3 files changed

Lines changed: 0 additions & 9 deletions

File tree

pkg/podgroupcontroller/controllers/metadata/pod.go

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -115,7 +115,6 @@ func calculatedAllocatedResources(
115115
func calculateRequestedResources(
116116
ctx context.Context, pod *v1.Pod, kubeClient client.Client, draClaims []*resourceapi.ResourceClaim,
117117
) (v1.ResourceList, error) {
118-
// Spec-only aggregation: requested reflects the desired target.
119118
requestedResources := resourcehelpers.AggregateContainerRequests(pod, resourcehelpers.PodResourcesOptions{})
120119
gpuSharingRequestedResources, err := resources.ExtractGPUSharingRequestedResources(pod)
121120
if err != nil {

pkg/scheduler/api/pod_info/pod_info.go

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -401,12 +401,6 @@ func getPodGroupID(pod *v1.Pod) common_info.PodGroupID {
401401
return ""
402402
}
403403

404-
// getPodResourceRequest returns the pod's total resource request.
405-
//
406-
// Aggregation is delegated to upstream k8s.io/component-helpers, which implements
407-
// both the sidecar formula (KEP-753) and the in-place resize effective-request
408-
// model (KEP-1287): max(spec, enacted, allocated), or max(enacted, allocated) when
409-
// the kubelet has marked the resize Infeasible.
410404
func getPodResourceRequest(pod *v1.Pod) *resource_info.ResourceRequirements {
411405
reqs := resourcehelpers.AggregateContainerRequests(pod, resourcehelpers.PodResourcesOptions{
412406
UseStatusResources: true,

pkg/scheduler/cache/pod_transform.go

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -75,8 +75,6 @@ func compactContainerStatuses(statuses []v1.ContainerStatus) []v1.ContainerStatu
7575
return compact
7676
}
7777

78-
// compactConditions keeps only the PodResizePending condition, which drives
79-
// Infeasible accounting in the effective-request model.
8078
func compactConditions(conditions []v1.PodCondition) []v1.PodCondition {
8179
for _, c := range conditions {
8280
if c.Type == v1.PodResizePending {

0 commit comments

Comments
 (0)