Skip to content

Commit fd7bfe9

Browse files
KaiPilotBotgshaibi
andauthored
chore(chart): rename global.fips to global.fipsMode with on/off values (#2011)
Signed-off-by: gshaibi <gshaibi@nvidia.com> Co-authored-by: Guy Shaibi <39763067+gshaibi@users.noreply.github.com>
1 parent f218c69 commit fd7bfe9

4 files changed

Lines changed: 14 additions & 8 deletions

File tree

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,5 @@
1+
kind: Changed
2+
body: Renamed Helm value global.fips to global.fipsMode with on/off options
3+
custom:
4+
Issue: "1906"
5+
Author: ""

deployments/kai-scheduler/templates/_helpers.tpl

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -25,13 +25,13 @@ argocd.argoproj.io/hook-delete-policy: BeforeHookCreation,HookSucceeded
2525

2626
{{/*
2727
Resolves a component image tag: explicit tag, then global.tag, then the chart
28-
version. When global.fips is set, appends "-fips" to whatever tag resolves so
28+
version. When global.fipsMode is "on", appends "-fips" to whatever tag resolves so
2929
the FIPS image variants are used. Usage:
3030
{{ include "kai-scheduler.imageTag" (dict "root" $ "tag" .Values.<svc>.image.tag) }}
3131
*/}}
3232
{{- define "kai-scheduler.imageTag" -}}
3333
{{- $tag := .tag | default .root.Values.global.tag | default .root.Chart.AppVersion -}}
34-
{{- if .root.Values.global.fips -}}{{- $tag = printf "%s-fips" $tag -}}{{- end -}}
34+
{{- if eq .root.Values.global.fipsMode "on" -}}{{- $tag = printf "%s-fips" $tag -}}{{- end -}}
3535
{{- $tag -}}
3636
{{- end -}}
3737

deployments/kai-scheduler/tests/fips_test.yaml

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
# Copyright 2026 NVIDIA CORPORATION
22
# SPDX-License-Identifier: Apache-2.0
33

4-
suite: test global.fips image tag suffix
4+
suite: test global.fipsMode image tag suffix
55

66
set:
77
kaiConfigDeployer:
@@ -31,9 +31,9 @@ tests:
3131
value: registry/local/kai-scheduler/crd-upgrader:0.0.0
3232
template: hooks/pre/crd-upgrader.yaml
3333

34-
- it: should suffix all image tags when global.fips is enabled
34+
- it: should suffix all image tags when global.fipsMode is on
3535
set:
36-
global.fips: true
36+
global.fipsMode: "on"
3737
asserts:
3838
- equal:
3939
path: spec.scheduler.service.image.tag
@@ -64,9 +64,9 @@ tests:
6464
value: registry/local/kai-scheduler/crd-upgrader:0.0.0-fips
6565
template: hooks/pre/crd-upgrader.yaml
6666

67-
- it: should suffix explicit per-service and global tags when global.fips is enabled
67+
- it: should suffix explicit per-service and global tags when global.fipsMode is on
6868
set:
69-
global.fips: true
69+
global.fipsMode: "on"
7070
global.tag: v1.2.3
7171
scheduler.image.tag: v9.9.9
7272
asserts:

deployments/kai-scheduler/values.yaml

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,8 @@ global:
1111
tag: ""
1212
# Use FIPS-enabled images: appends "-fips" to every resolved image tag
1313
# (whether it comes from a per-service tag, global.tag or the chart version)
14-
fips: false
14+
# Valid values: "on" | "off"
15+
fipsMode: "off"
1516
imagePullPolicy: IfNotPresent
1617
securityContext: {}
1718
podSecurityContext: {}

0 commit comments

Comments
 (0)