feat(admission): add NvFractions request validation foundation - #2040
Open
davidLif wants to merge 1 commit into
Open
feat(admission): add NvFractions request validation foundation#2040davidLif wants to merge 1 commit into
davidLif wants to merge 1 commit into
Conversation
davidLif
force-pushed
the
codex/nvfractions-foundation
branch
from
August 10, 2026 10:02
25c063d to
32d175d
Compare
davidLif
changed the base branch from
main
to
codex/fix-reservation-bindrequest-cache-lag
August 10, 2026 10:03
|
Total coverage: 54.6% -> 54.7% (delta 0.10%) Merging this branch changes the coverage (1 decrease, 1 increase)
Coverage by fileChanged files (no unit tests)
Please note that the "Total", "Covered", and "Missed" counts above refer to code statements instead of lines of code. The value in brackets refers to the test coverage of that file in the old version of the code. Changed unit test files
|
davidLif
force-pushed
the
codex/nvfractions-foundation
branch
from
August 11, 2026 13:46
32d175d to
6e7a222
Compare
davidLif
changed the base branch from
codex/fix-reservation-bindrequest-cache-lag
to
main
August 11, 2026 13:46
davidLif
force-pushed
the
codex/nvfractions-foundation
branch
from
August 11, 2026 13:48
6e7a222 to
965c684
Compare
davidLif
marked this pull request as ready for review
August 11, 2026 13:52
davidLif
force-pushed
the
codex/nvfractions-foundation
branch
2 times, most recently
from
August 17, 2026 06:39
0931678 to
7789c35
Compare
Signed-off-by: davidLif <davidshani12@gmail.com>
davidLif
force-pushed
the
codex/nvfractions-foundation
branch
from
August 17, 2026 11:00
7789c35 to
e8dedaf
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Stack PR 1/9 for GPU sharing migration.
Base:
mainHead:
codex/nvfractions-foundationThis adds the common NvFractions request parsing and validation foundation used by later scheduler, binder, and admission changes. It introduces shared constants, GPU sharing resource helpers, validation helpers, and admission validation coverage for NvFractions-style GPU memory requests.
Related Issues
N/A
Checklist
make changelog(or applied theskip-changeloglabel). Do not editCHANGELOG.mddirectly — pending fragments are folded into it at release time.Breaking Changes
None.
Additional Notes
Validation run:
go test ./pkg/common/resources ./pkg/admission/webhook/v1alpha2/gpusharing